⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@hougantc-nvda
Copy link
Contributor

Description

Remove explicit extension for urdf asset importer version no longer necessary.

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

@github-actions github-actions bot added isaac-sim Related to Isaac Sim team isaac-lab Related to Isaac Lab team labels Jan 16, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 16, 2026

Greptile Summary

This PR removes the explicit version constraint (2.4.36) from the isaacsim.asset.importer.urdf extension, allowing Isaac Sim 6.0 to use whatever version of the URDF importer is bundled with the release.

Changes:

  • Updated extension dependency declarations in kit configuration files to use version-agnostic syntax
  • Modified UrdfConverter class to check for and enable the extension without version suffix
  • Updated all test files to use the version-agnostic extension name
  • Added changelog entry documenting this fix

Impact:
This change improves forward compatibility by removing the hardcoded version dependency that was specific to Isaac Sim 5.x. The extension system will now automatically use the appropriate version of the URDF importer bundled with each Isaac Sim release.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward, consistent across all files, and well-documented. This is a simple string replacement removing hardcoded version constraints. The pattern is applied uniformly to kit files, Python code, and tests. No logic changes or complex refactoring involved.
  • No files require special attention

Important Files Changed

Filename Overview
apps/isaaclab.python.kit Removed explicit version constraint (2.4.36) from isaacsim.asset.importer.urdf extension dependency
apps/isaacsim_5/isaaclab.python.kit Removed explicit version constraint (2.4.36) from isaacsim.asset.importer.urdf extension dependency
source/isaaclab/isaaclab/sim/converters/urdf_converter.py Updated extension name checks and enable calls to use version-agnostic isaacsim.asset.importer.urdf instead of versioned string
source/isaaclab/test/sim/test_spawn_from_files.py Updated test to use version-agnostic extension name for URDF importer in enable_extension and get_extension_path_from_name calls
source/isaaclab/test/sim/test_urdf_converter.py Updated test to use version-agnostic extension name for URDF importer in enable_extension and get_extension_path_from_name calls
source/isaaclab/docs/CHANGELOG.rst Added changelog entry for version 0.50.6 documenting removal of explicit URDF importer extension version dependency

Sequence Diagram

sequenceDiagram
    participant User
    participant App as Isaac Sim App
    participant Converter as UrdfConverter
    participant ExtMgr as Extension Manager
    participant URDFExt as URDF Importer Extension
    
    User->>App: Launch with isaaclab.python.kit
    App->>ExtMgr: Load dependencies
    ExtMgr->>URDFExt: Load isaacsim.asset.importer.urdf<br/>(no version constraint)
    
    User->>Converter: Initialize UrdfConverter(cfg)
    Converter->>ExtMgr: is_extension_enabled("isaacsim.asset.importer.urdf")
    ExtMgr-->>Converter: Check result
    
    alt Extension not enabled
        Converter->>ExtMgr: enable_extension("isaacsim.asset.importer.urdf")
        ExtMgr->>URDFExt: Enable extension
    end
    
    Converter->>URDFExt: acquire_urdf_interface()
    URDFExt-->>Converter: Return interface
    
    User->>Converter: Convert URDF to USD
    Converter->>URDFExt: URDFParseFile command
    Converter->>URDFExt: URDFImportRobot command
    URDFExt-->>Converter: Generated USD asset
Loading

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 16, 2026

Greptile's behavior is changing!

From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section.

This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR".

# Isaac Sim Extra
"isaacsim.asset.importer.mjcf" = {}
"isaacsim.asset.importer.urdf" = {version = "2.4.36", exact = true}
"isaacsim.asset.importer.urdf" = {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's keep this for the 5.X app files since we want to use this exact version for 5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

isaac-lab Related to Isaac Lab team isaac-sim Related to Isaac Sim team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants