-
Notifications
You must be signed in to change notification settings - Fork 2.9k
For IsaacSim 6.0, remove explicit urdf asset importer extension version #4408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/isaacsim-6-0
Are you sure you want to change the base?
For IsaacSim 6.0, remove explicit urdf asset importer extension version #4408
Conversation
Greptile SummaryThis PR removes the explicit version constraint (2.4.36) from the Changes:
Impact: Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant App as Isaac Sim App
participant Converter as UrdfConverter
participant ExtMgr as Extension Manager
participant URDFExt as URDF Importer Extension
User->>App: Launch with isaaclab.python.kit
App->>ExtMgr: Load dependencies
ExtMgr->>URDFExt: Load isaacsim.asset.importer.urdf<br/>(no version constraint)
User->>Converter: Initialize UrdfConverter(cfg)
Converter->>ExtMgr: is_extension_enabled("isaacsim.asset.importer.urdf")
ExtMgr-->>Converter: Check result
alt Extension not enabled
Converter->>ExtMgr: enable_extension("isaacsim.asset.importer.urdf")
ExtMgr->>URDFExt: Enable extension
end
Converter->>URDFExt: acquire_urdf_interface()
URDFExt-->>Converter: Return interface
User->>Converter: Convert URDF to USD
Converter->>URDFExt: URDFParseFile command
Converter->>URDFExt: URDFImportRobot command
URDFExt-->>Converter: Generated USD asset
|
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
| # Isaac Sim Extra | ||
| "isaacsim.asset.importer.mjcf" = {} | ||
| "isaacsim.asset.importer.urdf" = {version = "2.4.36", exact = true} | ||
| "isaacsim.asset.importer.urdf" = {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's keep this for the 5.X app files since we want to use this exact version for 5.1
Description
Remove explicit extension for urdf asset importer version no longer necessary.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there