Support class static methods with "use step" / "use workflow" #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ff9e014 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (19 failed)mongodb (1 failed):
redis (1 failed):
starter (16 failed):
turso (1 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
|
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for class static methods with "use step" and "use workflow" directives in the SWC compiler plugin. Previously, the plugin would walk through these methods but didn't apply any transformations.
Key changes:
- Extended the SWC plugin to properly transform static class methods with step/workflow directives
- Added tracking for class context to generate qualified names (ClassName.methodName) for static methods
- Implemented proper registration and property assignment logic for static step and workflow methods
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/swc-plugin-workflow/transform/src/lib.rs | Core transformation logic: added class name tracking, static method handling in visit_mut_class_method, and registration/assignment of static methods after class declarations |
| packages/swc-plugin-workflow/transform/tests/fixture/static-method-workflow/* | Test fixtures for static workflow methods showing expected transformations across step/workflow/client modes |
| packages/swc-plugin-workflow/transform/tests/fixture/static-method-step/* | Test fixtures for static step methods showing expected transformations across step/workflow/client modes |
| packages/swc-plugin-workflow/transform/tests/errors/instance-methods/* | Updated error test outputs to reflect static method transformations while maintaining instance method errors |
| workbench/example/workflows/99_e2e.ts | Added example classes (MathService, Calculator, AllInOneService) demonstrating static method usage patterns |
| packages/core/e2e/e2e.test.ts | Added e2e tests validating static workflow methods calling static step methods |
| .changeset/shiny-brooms-invite.md | Changeset documenting the feature addition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
VaguelySerious
approved these changes
Jan 11, 2026
The SWC compiler plugin had logic to walk through class static methods with "use step" / "use workflow", but no actual transformation was being applied. This fixes that.
TooTallNate
force-pushed
the
01-08-support_class_static_methods_with_use_step___use_workflow_
branch
from
4e49fd8 to
ff9e014
Compare
pranaygp
reviewed
Jan 13, 2026
| async anotherInstance() { | ||
| 'use workflow'; | ||
| return 'also not allowed'; | ||
| } |
Collaborator
There was a problem hiding this comment.
should we also add test case for arrow syntax or regular function defined as a static property (not static fn)?
Member
Author
There was a problem hiding this comment.
will do in a follow-up PR
pranaygp
approved these changes
Jan 13, 2026
Collaborator
pranaygp
left a comment
pranaygp
left a comment
There was a problem hiding this comment.
left 1 edge case comment but lgtm
TooTallNate
deleted the
01-08-support_class_static_methods_with_use_step___use_workflow_
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SWC compiler plugin had logic to walk through class static methods with "use step" / "use workflow", but no actual transformation was being applied. This fixes that.