fix: use insert ignore for filecache_extended #48564
Open
Conversation
The current approach is to insert a new row and, if a unique constraint violation occurs, update an existing one. PostgreSQL logs the unique constraint violation as error "duplicate key value violates unique constraint". Our Adapter.insertIgnoreConflict method provides a way to run an insert query without logging such errors by using the vendor-specific sql extensions like "on conflict do nothing" on Postgres. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
force-pushed
the
bug/19494/insert-ignore-conflict-for-filecache-extended
branch
from
cda4948 to
af89838
Compare
nickvergessen
approved these changes
Oct 25, 2024
Member
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
At least seems to solve the issue on 29 (without sharding)
Member
|
@kesselb any chance to continue/finalize this? |
Contributor
|
I guess, sharding support is a blocking problem? |
Contributor
Author
Yep, I wrote down my findings at #19494 (comment) and handed the ticket over to Stephan. |
Member
|
The fix could applied on the older versions never the less? |
Merged
Merged
Merged
Contributor
|
Hi, @kesselb can we push this forward somehow? |
Merged
Member
|
Let's wait until current performance is sorted out? |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
duplicate key value violates unique constraint#19494Summary
TODO
Checklist