Conversation
nextcloud-bot
requested review from
CarlSchwan,
come-nc,
leftybournes and
provokateurin
and removed request for
a team
nextcloud-bot
requested review from
Altahrim,
AndyScherzinger,
blizzz,
nickvergessen,
skjnldsv and
sorbaugh
Signed-off-by: Worker Builder <worker-builder@nextcloud.com>
Altahrim
force-pushed
the
release/33.0.0_rc1
branch
from
343c2a2 to
085a252
Compare
|
I am again kindly asking to not be included in another set of PRs that have no relevance for me. I have asked for this in #57545 (comment) already and given that it seems unclear to me how many more rounds of this you are planning to do I would kindly ask again to please arrange that I am not constantly included with something that is not relevant for or related to me at all. Thank you. |
|
As stated last time referring to your comment see #57545 (comment) @cherti, removing the milestone assignment would have done the job. Since you didn't do so back then I took the liberty to do it for you. So from now on you won't be @ mentioned in the such PRs any longer. |
|
Thank you very much. It doesn't look to me like I can assign anything to any milestone, it is something that would have had to be done from your side anyways, from how it looked from my side. Hence I was irritated why it wasn't done before. |
|
I agree that it is very annoying to get included in such thing completely irrelevant for me automatically / without any involvement from my side. I even have no idea what "milestone" is and why i should do anything which i'm not involved at all. |
|
@iasdeoupxe removed the milestone form you PR as well, so no more @ mention pings from now on. For both of you (well, any contributor / PR owner) I thought the milestone is visible in the right sidebar of the PR and can be set/unset. Thanks for clarifying that to me 👍 As for your PR I did assign a milestone since I was optimistic I could wrap it up for the release but also lack further detail knowledge on the missing parts. |
|
@AndyScherzinger Thanks for handling 👍 There is something called "Milestone" on my PR at the right side but i have no means to change / update it (and i wouldn't touch it anyway as i have no insights on the purpose of it :-)) |
|
We will discuss to adjust in the future so external contributors are not pinged. |
|
Such a reminder to finish off work is also somewhat irritating when the ball for a PR lies with the nextcloud staff and not the contributer. So maybe it is worthwhile discussing how you assign milestones as well, while you're at it. it feels a little like there isn't much thought put into it right now. |
6 participants
Nextcloud 33
Pending PRs:
trusted_domainsandoverwrite.cli.urlsensitive config values #45085always_populate_raw_post_data#53583 ✅occ admin-delegation:add#46617last_seenwhen user session is validated #50835downloadShareendpoint compatible with legacy behavior #56967personalcircles circles#395 ⚠allow_adding_any_group_membersoption circles#398 ⚠group_backendoption to mirroring the circle as a group circles#401 ⚠allow_files_filtered_by_circlesoption circles#400 ⚠allow_listed_circlesoption circles#399 ⚠