Address feedback: fix IMAGE_REVISION handling and improve SSL certificate validation#53
Merged
Address feedback: fix IMAGE_REVISION handling and improve SSL certificate validation#53
Conversation
Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>
Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>
Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] WIP address feedback on support for trusting Aspire dev certs
Address feedback: fix IMAGE_REVISION handling and improve SSL certificate validation
Jan 28, 2026
TimHess
approved these changes
Jan 28, 2026
There was a problem hiding this comment.
Pull request overview
This PR addresses feedback from PR #52 by improving the robustness of the build script and enhancing SSL certificate validation security. The changes fix edge cases in image tag generation and replace string-based certificate matching with cryptographic verification.
Changes:
- Fixed IMAGE_REVISION handling to prevent malformed image tags when metadata files contain only whitespace
- Added error handling for missing ADDITIONAL_TAGS and IMAGE_REVISION metadata files
- Replaced insecure DN string-based certificate matching with cryptographic signature verification and CA basic constraints checking
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build.ps1 | Added trimming and error handling for IMAGE_REVISION and ADDITIONAL_TAGS metadata files to prevent build failures and malformed image tags |
| shared/ssl-config/SslTrustConfiguration.java | Replaced string-based DN matching with cryptographic signature verification and added CA basic constraints checking to improve certificate validation security |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TimHess
added a commit
that referenced
this pull request
Jan 28, 2026
* Update eureka-server/patches/application.properties.patch * Fix line count in patch * Update build.ps1 to trim/join IMAGE_REVISION and check for non-empty * Use cryptographic signature verification in SslTrustConfiguration --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>
TimHess
added a commit
that referenced
this pull request
Jan 29, 2026
* Update eureka-server/patches/application.properties.patch * Fix line count in patch * Update build.ps1 to trim/join IMAGE_REVISION and check for non-empty * Use cryptographic signature verification in SslTrustConfiguration --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback from PR #52 on build script robustness and SSL certificate validation security.
Changes
build.ps1: Trim and join IMAGE_REVISION content before checking. Prevents trailing dashes in image tags when metadata files contain only whitespace.
SslTrustConfiguration.java: Replace string-based DN matching with cryptographic signature verification. Checks CA basic constraints before trusting signed certificates.
Added error handling for missing ADDITIONAL_TAGS files
Security
CodeQL scan: 0 alerts
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.