⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Support trusting Aspire dev certs#52

Open
TimHess wants to merge 5 commits intomainfrom
https
Open

Support trusting Aspire dev certs#52
TimHess wants to merge 5 commits intomainfrom
https

Conversation

@TimHess
Copy link
Member

@TimHess TimHess commented Jan 9, 2026

  • Bump to Spring Boot 3.5.10
  • Update versions recommended in readmes
  • Add support for listening on https with local dev certs from .NET/Aspire

Reduces the need for #40

@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 27, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 27, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 27, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 27, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 27, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 27, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 27, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 27, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@TimHess TimHess marked this pull request as ready for review January 28, 2026 00:57
Copilot AI review requested due to automatic review settings January 28, 2026 00:57
@TimHess TimHess requested a review from bart-vmware January 28, 2026 00:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the local-dev Spring-based container images to newer Spring Boot versions and adds a shared mechanism to trust Aspire/.NET development certificates (notably for Spring Boot Admin).

Changes:

  • Bump Spring Boot version metadata to 3.5.10 across images.
  • Add Spring Boot Admin configuration patches for Steeltoe actuator compatibility and SSL trust via a custom ClientHttpConnector.
  • Introduce shared SSL trust configuration and update the build script to apply patches more robustly and copy shared SSL sources.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
uaa-server/README.md Updates UAA image tag and documentation links.
spring-boot-admin/patches/steeltoe-admin-config.patch Adds SBA WebClient customization to tolerate Steeltoe actuator index responses in AOT.
spring-boot-admin/patches/spring-boot-admin-ssl-config.patch Adds SBA ClientHttpConnector bean wired to a shared X509TrustManager.
spring-boot-admin/patches/enable-springbootadmin.patch Enables SBA server and expands component scanning/imports needed for SSL + Steeltoe config.
spring-boot-admin/patches/build.gradle.patch Adjusts build-image environment settings (incl. native image build args).
spring-boot-admin/patches/application.properties.patch Sets SBA defaults and configures SSL package logging.
spring-boot-admin/metadata/SPRING_BOOT_VERSION Bumps Spring Boot version metadata to 3.5.10.
spring-boot-admin/metadata/IMAGE_VERSION Bumps SBA image version metadata.
spring-boot-admin/README.md Updates SBA run instructions/tag.
shared/ssl-config/SslTrustConfiguration.java Adds shared trust manager that loads dev certs from standard locations/env vars.
eureka-server/patches/application.properties.patch Adds Eureka properties and enables SSL package logging.
eureka-server/metadata/SPRING_BOOT_VERSION Bumps Spring Boot version metadata to 3.5.10.
eureka-server/metadata/IMAGE_REVISION Introduces image revision metadata.
eureka-server/README.md Updates Eureka run instructions/tag.
config-server/patches/enableconfigserver.patch Updates Config Server bootstrap (enables config server/discovery + logs package info).
config-server/patches/application.properties.patch Adds Config Server properties and enables SSL package logging.
config-server/metadata/SPRING_BOOT_VERSION Bumps Spring Boot version metadata to 3.5.10.
config-server/metadata/IMAGE_VERSION Bumps Config Server image version metadata.
config-server/metadata/IMAGE_REVISION Changes revision metadata content.
config-server/README.md Updates Config Server run instructions/tags.
build.ps1 Enhances patch application behavior and copies shared SSL config into generated projects.
AGENTS.md Adds agent guidance for patch handling/build workflow.
.gitattributes Enforces LF endings for .patch files.
Comments suppressed due to low confidence (1)

config-server/patches/enableconfigserver.patch:24

  • This patch appears to truncate ConfigServer.java and does not include the closing braces for the main method and class. When applied, it will likely produce invalid Java and fail compilation. Please update the patch so the resulting file still ends with the appropriate } braces (and include the necessary context lines so patch can apply cleanly).
 	public static void main(String[] args) {
+        Package pkg = EnableConfigServer.class.getPackage();
+        logger.info("{} {} by {}", pkg.getImplementationTitle(), pkg.getImplementationVersion(), pkg.getImplementationVendor());
 		SpringApplication.run(ConfigServer.class, args);


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI commented Jan 28, 2026

@TimHess I've opened a new pull request, #53, to work on those changes. Once the pull request is ready, I'll request review from you.

@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@github-actions
Copy link

To run the UAA server image built for this pull request:

docker run --rm -d --pull=always -p 8080:8080 --name uaa-pr steeltoe.azurecr.io/uaa-server:pr-52

@github-actions
Copy link

To run the Eureka server image built for this pull request:

docker run --rm -d --pull=always -p 8761:8761 --name eureka-pr steeltoe.azurecr.io/eureka-server:pr-52

@github-actions
Copy link

To run the Spring Cloud Config Server image built for this pull request:

docker run --rm -d --pull=always -p 8888:8888 --name config-pr steeltoe.azurecr.io/config-server:pr-52

@github-actions
Copy link

To run the Spring Boot Admin server image built for this pull request:

docker run --rm -d --pull=always -p 9099:9099 --name sba-pr steeltoe.azurecr.io/spring-boot-admin:pr-52

@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@SteeltoeOSS SteeltoeOSS deleted a comment from github-actions bot Jan 28, 2026
@TimHess TimHess requested a review from Copilot January 28, 2026 21:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 27 out of 27 changed files in this pull request and generated 8 comments.

Comments suppressed due to low confidence (1)

config-server/patches/application.properties.patch:15

  • This logging category likely won't affect the shared trust configuration at runtime. build.ps1 copies shared/ssl-config/SslTrustConfiguration.java into the app's base package and rewrites its package declaration to io.steeltoe.docker.<serverName> (build.ps1:300-315), so the logger name won’t be under io.steeltoe.docker.ssl. Consider switching this to logging.level.io.steeltoe.docker=INFO or the concrete app package so the SSL trust logs can actually be controlled.
+auth.enabled=false
+logging.level.io.steeltoe.docker.ssl=INFO


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

TimHess and others added 3 commits January 29, 2026 10:06
- Log dependencies requested in calls to start.spring.io
- Enhance patch handling to catch more failure scenarios
- Use eol=lf for .patch files
- fix enableconfigserver.patch
- add custom deserialization for aot/native-compiled SBA to avoid breakage over 'type' property in Steeltoe responses
fixup metadata

skip self-replication in Eureka
* Update eureka-server/patches/application.properties.patch
* Fix line count in patch
* Update build.ps1 to trim/join IMAGE_REVISION and check for non-empty
* Use cryptographic signature verification in SslTrustConfiguration

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TimHess <3947063+TimHess@users.noreply.github.com>
- Fix logging.level namespace to match actual package after build-time rewriting (io.steeltoe.docker instead of io.steeltoe.docker.ssl)

- Correct AGENTS.md patch documentation for unified diff hunk headers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants