Build-On-Save: fix build_runner serving ErrorBundles twice in the same cycle #2571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Techatrix
requested changes
Jan 14, 2026
Member
Techatrix
left a comment
Techatrix
left a comment
There was a problem hiding this comment.
The code in runSteps should be removed instead. Error bundles should be sent as soon as possible instead of waiting until the entire build has finished.
llogick
force-pushed
the
brunner-serving-doubles
branch
from
7b7f900 to
2fc1223
Compare
Techatrix
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serveWatchErrorBundle called from
runStepsandmakeStep