⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@ymc9
Copy link
Member

@ymc9 ymc9 commented Dec 29, 2025

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

📝 Walkthrough

Walkthrough

Added support for Prisma Client version 7 by introducing version detection in the getDMMF function. The function now conditionally imports and uses _getDMMF7 from @prisma/internals-v7 when Prisma version is 7.0.0 or higher, otherwise falls back to the existing _getDMMF implementation.

Changes

Cohort / File(s) Summary
Prisma version compatibility
packages/sdk/src/prisma.ts
Added conditional version detection in getDMMF function; imported _getDMMF7 from @prisma/internals-v7 and normalizedRelative utility; function now delegates to version-appropriate implementation (7+ vs. legacy).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided by the author, making it impossible to assess relevance to the changeset. Add a pull request description explaining the Prisma 7 compatibility issue, the version mismatch problem, and how the changes resolve it.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding Prisma 7 compatibility by handling @prisma/internals version differences.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/prisma-7-compact

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ea93dd6 and 6e90457.

⛔ Files ignored due to path filters (2)
  • packages/sdk/package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !**/*.yaml
📒 Files selected for processing (1)
  • packages/sdk/src/prisma.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
  • GitHub Check: build-test (20.x)
  • GitHub Check: dependency-review
  • GitHub Check: build-test (20.x)
  • GitHub Check: build-test (20.x)

@ymc9 ymc9 merged commit 0173706 into dev Dec 29, 2025
8 checks passed
@ymc9 ymc9 deleted the fix/prisma-7-compact branch December 29, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants