This is a refactoring proposal in itself;#27
Closed
nglmercer wants to merge 11 commits intowebviewjs:mainfrom
Closed
This is a refactoring proposal in itself;#27nglmercer wants to merge 11 commits intowebviewjs:mainfrom
nglmercer wants to merge 11 commits intowebviewjs:mainfrom
Conversation
Converted example and test files from JavaScript/MJS to TypeScript, adding new TypeScript-based tests and examples. Refactored Rust source code by removing src/browser_window.rs and src/webview.rs, introducing new high-level modules under src/tao and src/wry, and adding src/high_level.rs. Updated Cargo.toml dependencies, removing Linux-specific dependencies and adding serde_json. Updated index.d.ts and index.js to reflect new API structure. This improves type safety, maintainability, and aligns the codebase with modern TypeScript and Rust best practices.
handles the new DEB822 .sources files for build
install and use xvfb for bun run test change deps in arm64 and armv7
limux arm64 ubuntu latest to 22.04 change params con cargo build
nglmercer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tested it on Windows and Linux. Could you review it and fix any issues you find? Alternatively, it could be versioned or put in a separate repository. I'm open to making any necessary changes.
all the previous examples work, only the event loop and event listeners are different.