This repository was archived by the owner on Dec 19, 2025. It is now read-only.
fix: "Channel closed" error in child on graceful shutdown after SIGTERM#321
Open
everhardt wants to merge 4 commits intowclr:masterfrom
Open
fix: "Channel closed" error in child on graceful shutdown after SIGTERM#321everhardt wants to merge 4 commits intowclr:masterfrom
everhardt wants to merge 4 commits intowclr:masterfrom
Conversation
…er SIGTERM" This reverts commit 54e7811.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #320
I could not identify a reason why
child.disconnect()is needed at all:willTerminate === false, the chill will be killed anyway (and Fix: immediate recompilation #256 is also suggesting it is not needed there).willTerminate === true, the child might need to require new files, for which the IPC is needed, so there we cannot disconnect. When the client exists, the IPC is disconnected anyway.