chore(deps-dev): bump the gha group across 1 directory with 4 updates #3578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps the gha group with 4 updates in the /packages/opentelemetry-instrumentation-vertexai directory: [pytest-sugar](https://github.com/Teemu/pytest-sugar), [ruff](https://github.com/astral-sh/ruff), [pytest-asyncio](https://github.com/pytest-dev/pytest-asyncio) and [vcrpy](https://github.com/kevin1024/vcrpy). Updates `pytest-sugar` from 1.0.0 to 1.1.1 - [Release notes](https://github.com/Teemu/pytest-sugar/releases) - [Changelog](https://github.com/Teemu/pytest-sugar/blob/main/CHANGES.rst) - [Commits](Teemu/pytest-sugar@v1.0.0...v1.1.1) Updates `ruff` from 0.14.11 to 0.14.12 - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](https://github.com/astral-sh/ruff/commits) Updates `pytest-asyncio` from 0.23.8 to 1.2.0 - [Release notes](https://github.com/pytest-dev/pytest-asyncio/releases) - [Commits](pytest-dev/pytest-asyncio@v0.23.8...v1.2.0) Updates `vcrpy` from 6.0.2 to 7.0.0 - [Release notes](https://github.com/kevin1024/vcrpy/releases) - [Changelog](https://github.com/kevin1024/vcrpy/blob/master/docs/changelog.rst) - [Commits](kevin1024/vcrpy@v6.0.2...v7.0.0) --- updated-dependencies: - dependency-name: pytest-sugar dependency-version: 1.1.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: gha - dependency-name: ruff dependency-version: 0.14.12 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: gha - dependency-name: pytest-asyncio dependency-version: 1.2.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: gha - dependency-name: vcrpy dependency-version: 7.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: gha ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
the
dependencies
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 1b6a16a in 2 minutes and 29 seconds. Click for details.
- Reviewed
27lines of code in1files - Skipped
1files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/opentelemetry-instrumentation-vertexai/pyproject.toml:33
- Draft comment:
Updated pytest-sugar to 1.1.1. Consider if strict pinning (==1.1.1) is desired or if a version range (e.g., ">=1.1.1,<2") might be preferable for flexibility in patch updates. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
2. packages/opentelemetry-instrumentation-vertexai/pyproject.toml:40
- Draft comment:
The pytest-asyncio range was extended to <1.3.0 but still allows versions as low as 0.23.0. If the intent is to upgrade to the 1.x series (e.g., 1.2.0), consider bumping the lower bound to >=1.2.0. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment is making an assumption about the author's intent ("If the intent is to upgrade to the 1.x series"). The actual change just extends the upper bound from <0.24.0 to <1.3.0, which allows both 0.x and 1.x versions. This is a valid dependency range that maintains backward compatibility while allowing newer versions. The comment is speculative - it's suggesting a change based on a hypothetical intent rather than pointing out a concrete problem. There's no evidence that keeping the lower bound at 0.23.0 is wrong. This violates the rule about not making speculative comments. Perhaps there's a breaking change between pytest-asyncio 0.x and 1.x that would make it problematic to allow both version ranges? Maybe the author has specific knowledge that these versions are incompatible? Even if there were breaking changes, the comment doesn't provide evidence of this. It's phrased as "If the intent is..." which is speculative. Without concrete evidence of incompatibility or a specific issue, this is just a suggestion based on assumed intent, which violates the rules. This comment should be deleted. It's speculative ("If the intent is...") and doesn't point to a concrete issue. The change to widen the version range is valid and common practice. The comment asks the author to clarify intent rather than identifying a real problem.
3. packages/opentelemetry-instrumentation-vertexai/pyproject.toml:42
- Draft comment:
pytest-sugar is specified again in the test group. Ensure this duplication is intentional to keep both dev and test environments in sync. - Reason this comment was not posted:
Confidence changes required:30%<= threshold50%None
4. packages/opentelemetry-instrumentation-vertexai/pyproject.toml:44
- Draft comment:
vcrpy's version range was updated to allow versions <8, but the lower bound remains at 6.0.1. If the intent is to adopt v7.0.0 features, consider updating the lower bound to >=7.0.0 to avoid inadvertently using older versions. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% This comment is speculative and makes an assumption about intent ("If the intent is to adopt v7.0.0 features"). The change simply relaxes the upper bound to allow newer versions, which is a common practice for dependency management - it doesn't necessarily mean the code requires v7.0.0 features. The comment is asking the author to "consider" something based on a hypothetical scenario. This violates the rule about not making speculative comments ("If X, then Y is an issue"). There's no evidence in the diff that v7.0.0 features are being used or required. The change is simply making the dependency range more permissive, which is typically done to avoid unnecessary version conflicts. Could the PR author actually be adding code elsewhere that requires vcrpy 7.0.0 features, making this comment valid? Perhaps there are other files in the PR that use new vcrpy features that I cannot see. Even if other files use v7.0.0 features, I'm instructed to ignore cross-file issues and only focus on this file. Additionally, the rule states I should only comment if there's STRONG EVIDENCE of an issue. A speculative "if the intent is..." comment doesn't meet that bar. The change itself is just a dependency version update, which I'm told not to comment on. This comment should be deleted. It's speculative ("If the intent is..."), makes assumptions about what the author wants to do, and comments on a dependency version change. There's no evidence that v7.0.0 features are required. The rules explicitly state not to comment on dependency changes and not to make speculative comments.
Workflow ID: wflow_qRJcyJP0elKW0rPS
You can customize 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the gha group with 4 updates in the /packages/opentelemetry-instrumentation-vertexai directory: pytest-sugar, ruff, pytest-asyncio and vcrpy.
Updates
pytest-sugarfrom 1.0.0 to 1.1.1Release notes
Sourced from pytest-sugar's releases.
Changelog
Sourced from pytest-sugar's changelog.
Commits
8133503Release pytest-sugar 1.1.16798042Fix conflict with other Pytest plugins (#297)43bbdd0Release pytest-sugar 1.1.0855d661Feature - Playwright Support for Trace Zip Mapping (#296)2a5862aMerge pull request #293 from cgoldberg/add-py313ca26d98Add support for Python 3.1369989ebClarify license as BSD 3-Clause License3c86a5cMerge pull request #289 from deronnax/remove-packaging-depc123be0remove 'packaging' packageefafd9cMerge pull request #282 from penguinpee/mainUpdates
rufffrom 0.14.11 to 0.14.12Changelog
Sourced from ruff's changelog.
Commits
Updates
pytest-asynciofrom 0.23.8 to 1.2.0Release notes
Sourced from pytest-asyncio's releases.
... (truncated)
Commits
0d3988fci: Create GitHub release before publishing to PyPI.07c5a0bdocs: Include orphaned news fragment in changelog.be24582chore: Prepare release of v1.2.0.7aeb296docs: Streamline news fragments7b8311cci: Fixes a bug that prevented SSH signature from being stripped from release...9d4c2bddocs: Add changelog entry for Pyright compatibility.94f6106test: Added tests which assert that the event loop is reinstated if unset by ...df61991[pre-commit.ci] pre-commit autoupdatef1f7941Build(deps): Bump pytest from 8.4.1 to 8.4.2c77d3d3Build(deps): Bump twine from 6.1.0 to 6.2.0Updates
vcrpyfrom 6.0.2 to 7.0.0Release notes
Sourced from vcrpy's releases.
Changelog
Sourced from vcrpy's changelog.
... (truncated)
Commits
3278619Release v7.0.03fb62e0fix: correctly handle asyncio.run when loop exists8197865build(deps): update sphinx requirement from <8 to <9be651bdpre-commit: Autoupdatea6698edFix aiohttp tests48d0a2eFixed missingversion_stringattribute when used with urllib3>=2.3.05b858b1Fix lintc8d99a9Fix ruff configurationce27c63Merge pull request #736 from kevin1024/drop-python38ab8944dDrop python 3.8 supportDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsImportant
Update development dependencies in
pyproject.tomlforopentelemetry-instrumentation-vertexaipackage.pytest-sugarfrom 1.0.0 to 1.1.1 inpyproject.toml.rufffrom 0.14.11 to 0.14.12 inpyproject.toml.pytest-asynciofrom 0.23.8 to 1.2.0 inpyproject.toml.vcrpyfrom 6.0.2 to 7.0.0 inpyproject.toml.This description was created by
for 1b6a16a. You can customize this summary. It will automatically update as commits are pushed.