-
Notifications
You must be signed in to change notification settings - Fork 867
chore(deps-dev): bump the gha group across 1 directory with 3 updates #3574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps-dev): bump the gha group across 1 directory with 3 updates #3574
Conversation
Bumps the gha group with 3 updates in the /packages/opentelemetry-instrumentation-cohere directory: [pytest-sugar](https://github.com/Teemu/pytest-sugar), [ruff](https://github.com/astral-sh/ruff) and [vcrpy](https://github.com/kevin1024/vcrpy). Updates `pytest-sugar` from 1.0.0 to 1.1.1 - [Release notes](https://github.com/Teemu/pytest-sugar/releases) - [Changelog](https://github.com/Teemu/pytest-sugar/blob/main/CHANGES.rst) - [Commits](Teemu/pytest-sugar@v1.0.0...v1.1.1) Updates `ruff` from 0.14.11 to 0.14.12 - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](https://github.com/astral-sh/ruff/commits) Updates `vcrpy` from 6.0.2 to 7.0.0 - [Release notes](https://github.com/kevin1024/vcrpy/releases) - [Changelog](https://github.com/kevin1024/vcrpy/blob/master/docs/changelog.rst) - [Commits](kevin1024/vcrpy@v6.0.2...v7.0.0) --- updated-dependencies: - dependency-name: pytest-sugar dependency-version: 1.1.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: gha - dependency-name: ruff dependency-version: 0.14.12 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: gha - dependency-name: vcrpy dependency-version: 7.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: gha ... Signed-off-by: dependabot[bot] <[email protected]>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 2ab9090 in 2 minutes and 11 seconds. Click for details.
- Reviewed
25lines of code in1files - Skipped
1files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/opentelemetry-instrumentation-cohere/pyproject.toml:32
- Draft comment:
pytest-sugar version bump to 1.1.1 looks good and aligns with its release notes. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. packages/opentelemetry-instrumentation-cohere/pyproject.toml:43
- Draft comment:
vcrpy upper bound update (<8) permits v7.x, but the lower bound remains at 6.0.1. Consider bumping the lower bound to 7.0.0 if the intent is to require the new v7 features given that v7.0.0 is a major release. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment is speculative - it says "Consider bumping... if the intent is to require the new v7 features". This is asking the PR author to confirm their intention and making assumptions about what they might want. The PR author clearly chose to keep the lower bound at 6.0.1, which indicates they want to support both v6 and v7. The comment is essentially asking "are you sure you meant to do this?" which violates the rule about not asking the PR author to confirm their intention or explain their choices. The change is intentional - they're expanding compatibility, not requiring v7. Maybe the comment is trying to prevent a potential issue where v6 and v7 have incompatible APIs, and the code might not work with v6 anymore. However, without evidence that this is actually a problem, this is still speculative. Even if there could be compatibility issues between v6 and v7, the comment doesn't provide any evidence that such issues exist. It's purely speculative ("if the intent is to require"). Without concrete evidence of a problem, this violates the rule against speculative comments. This comment should be deleted. It's speculative and asks the PR author to confirm their intention ("if the intent is to require"), which violates the review rules. The PR author intentionally kept the lower bound at 6.0.1 to maintain backward compatibility while allowing v7.x.
Workflow ID: wflow_BtoMytADrdhKxjMk
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Bumps the gha group with 3 updates in the /packages/opentelemetry-instrumentation-cohere directory: pytest-sugar, ruff and vcrpy.
Updates
pytest-sugarfrom 1.0.0 to 1.1.1Release notes
Sourced from pytest-sugar's releases.
Changelog
Sourced from pytest-sugar's changelog.
Commits
8133503Release pytest-sugar 1.1.16798042Fix conflict with other Pytest plugins (#297)43bbdd0Release pytest-sugar 1.1.0855d661Feature - Playwright Support for Trace Zip Mapping (#296)2a5862aMerge pull request #293 from cgoldberg/add-py313ca26d98Add support for Python 3.1369989ebClarify license as BSD 3-Clause License3c86a5cMerge pull request #289 from deronnax/remove-packaging-depc123be0remove 'packaging' packageefafd9cMerge pull request #282 from penguinpee/mainUpdates
rufffrom 0.14.11 to 0.14.12Changelog
Sourced from ruff's changelog.
Commits
Updates
vcrpyfrom 6.0.2 to 7.0.0Release notes
Sourced from vcrpy's releases.
Changelog
Sourced from vcrpy's changelog.
... (truncated)
Commits
3278619Release v7.0.03fb62e0fix: correctly handle asyncio.run when loop exists8197865build(deps): update sphinx requirement from <8 to <9be651bdpre-commit: Autoupdatea6698edFix aiohttp tests48d0a2eFixed missingversion_stringattribute when used with urllib3>=2.3.05b858b1Fix lintc8d99a9Fix ruff configurationce27c63Merge pull request #736 from kevin1024/drop-python38ab8944dDrop python 3.8 supportDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsImportant
Update
pytest-sugar,ruff, andvcrpydependencies inpyproject.tomlforopentelemetry-instrumentation-cohere.pytest-sugarfrom 1.0.0 to 1.1.1 inpyproject.toml.rufffrom 0.14.11 to 0.14.12 inpyproject.toml.vcrpyfrom 6.0.2 to 7.0.0 inpyproject.toml.vcrpy7.0.0 drops support for Python 3.8.This description was created by
for 2ab9090. You can customize this summary. It will automatically update as commits are pushed.