-
Notifications
You must be signed in to change notification settings - Fork 221
Improve React, Vuejs and Angular integration pages #3948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…om the bundling with webpack guide
modules/ROOT/partials/integrations/angular-load-tinymce-independently.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Millie <[email protected]>
tiny-james
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just go and check that you are in the correct directory in the steps please.
@tiny-james, the command works as intended on macOS (iterm2 + zsh). Would it work differently on other OS(s)? |
kemister85
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked all staging builds to ensure partials are rendering- don't see any issues.
modules/ROOT/partials/module-loading/webpack-dev-dependencies.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Karl Kemister-Sheppard <[email protected]>
Co-authored-by: Karl Kemister-Sheppard <[email protected]>
Co-authored-by: Karl Kemister-Sheppard <[email protected]>
Co-authored-by: Karl Kemister-Sheppard <[email protected]>
Co-authored-by: Karl Kemister-Sheppard <[email protected]>
Will also resolve: TINY-13508
Site: Staging branch
Updated pages:
Changes:
Pre-checks:
feature/<version>/,hotfix/<version>/,staging/<version>/, orrelease/<version>/.modules/ROOT/nav.adochas been updated(if applicable).Included arelease noteentry for anyNew product features.If this is a minor release, updatedproductminorversioninantora.ymland added new supported versions entry inmodules/ROOT/partials/misc/supported-versions.adoc.Review: