-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Change the Docker Image used by the Presto module to prestodb/presto
#8946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your contribution, @linghengqian! In order to fix the build, please run |
this.waitStrategy =
new LogMessageWaitStrategy()
.withRegEx(".*======== SERVER STARTED ========.*")
.withStartupTimeout(Duration.of(60, ChronoUnit.SECONDS)); |
|
thanks for the update, @linghengqian ! I see everything green but failing locally. So, hopefully the other issue in presto repository is solved soon and the module can provide a reliable wait strategy. |
linghengqian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Since prestodb/presto#23226 and prestodb/presto#15916 have been resolved, it seems that there is nothing that can prevent the current PR from continuing to merge.
f1aba97 to
1a1a1f0
Compare
b1bad28 to
84b2e48
Compare
529072a to
c85e3ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After updating from presto 0.292 to presto 0.296, CI suddenly returned to normal.
I'm not sure if the bug mentioned in #3079 (comment) has been fixed.
The cause of this appears to be that
JdbcDatabaseContainerignores any configured wait strategies.
ghcr.io/trinodb/prestoand needs to be updated toprestodb/presto#8657 .prestodb/presto.