⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@linghengqian
Copy link
Contributor

@eddumelendez
Copy link
Member

Thanks for your contribution, @linghengqian! In order to fix the build, please run ./gradlew :presto:spotlessApply.

@linghengqian
Copy link
Contributor Author

linghengqian commented Jul 16, 2024

Thanks for your contribution, @linghengqian! In order to fix the build, please run ./gradlew :presto:spotlessApply.

this.waitStrategy =
            new LogMessageWaitStrategy()
                .withRegEx(".*======== SERVER STARTED ========.*")
                .withStartupTimeout(Duration.of(60, ChronoUnit.SECONDS));

@eddumelendez
Copy link
Member

thanks for the update, @linghengqian ! I see everything green but failing locally. So, hopefully the other issue in presto repository is solved soon and the module can provide a reliable wait strategy.

Copy link
Contributor Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After updating from presto 0.292 to presto 0.296, CI suddenly returned to normal.

I'm not sure if the bug mentioned in #3079 (comment) has been fixed.

The cause of this appears to be that JdbcDatabaseContainer ignores any configured wait strategies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Presto Module uses the outdated Docker Image of ghcr.io/trinodb/presto and needs to be updated to prestodb/presto

2 participants