Rename CustomBuildID -> UnsafeCustomBuildID and integration test it
#189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for user-controlled build IDs via spec.workerOptions.buildID, enabling rolling updates for non-workflow code changes while preserving new deployment creation for workflow code changes. Key changes: - Add BuildID field to WorkerOptions struct in API types - Update ComputeBuildID to use spec field instead of annotation - Implement drift detection by comparing deployed spec with desired spec - Only check for drift when buildID is explicitly set by user Drift detection currently monitors: replicas, minReadySeconds, container images, container resources (limits/requests), and init container images. Other fields (env vars, volumes, commands) are not monitored - this is documented in the BuildID field comment. Note: CRD regeneration includes some unrelated changes from controller-gen (default values for name fields, x-kubernetes-map-type annotations). These are standard regeneration artifacts and don't affect functionality. This solves deployment proliferation for PINNED versioning strategy where any pod spec change (image tag, env vars, resources) would generate a new build ID and create unnecessary deployments. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replace per-field comparison with SHA256 hash of user-provided pod template spec. This detects ALL changes (env vars, commands, volumes, etc.) rather than a subset of fields. Changes: - Add ComputePodTemplateSpecHash() using spew for deterministic hashing - Store hash in pod-template-spec-hash annotation on deployments - Compare hashes instead of individual fields for drift detection - Add backwards compatibility for legacy deployments without hash Tests: - 6 tests for hash computation (images, env vars, commands, volumes) - Updated drift detection tests including env var change case - Backwards compatibility test for deployments without hash annotation Docs: - Update BuildID field documentation to reflect hash-based detection
carlydf
changed the title
CustomBuildID -> UnsafeCustomBuildID and integration test it
eniko-dif
approved these changes
Jan 15, 2026
|
|
||
| func MakeBaseVersion(namespace, twdName, imageName string, status temporaliov1alpha1.VersionStatus, createDeployment, hasDeployment bool) temporaliov1alpha1.BaseWorkerDeploymentVersion { | ||
| func MakeBaseVersion(namespace, twdName, imageName, unsafeCustomBuildID string, status temporaliov1alpha1.VersionStatus, createDeployment, hasDeployment bool) temporaliov1alpha1.BaseWorkerDeploymentVersion { | ||
| buildID := unsafeCustomBuildID |
There was a problem hiding this comment.
nit: I think this logic should be handled inside the MakeBuildId function similarly how ComputeBuildID works to keep build ID handling logic at the same place.
| } | ||
| for _, info := range tcb.existingDeploymentInfos { | ||
| buildId := MakeBuildId(tcb.name, info.image, nil) | ||
| buildId := info.unsafeCustomBuildID |
There was a problem hiding this comment.
and then you also don't need to duplicate the logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
See title.
Why?
Checklist
Closes
How was this tested:
New test
Any docs updates needed?