♿️(frontend) fix subdoc opening and emoji pick focus #1745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
fix/a11y-emoji-picker-focus-and-enter
branch
from
70177ca to
7c90e7f
Compare
|
Size Change: +88 B (0%) Total Size: 4.17 MB
|
AntoLC
reviewed
Dec 18, 2025
src/frontend/apps/impress/src/features/docs/doc-editor/components/EmojiPicker.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-editor/components/EmojiPicker.tsx
Outdated
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-editor/components/EmojiPicker.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
113
to
120
| useKeyboardActivation( | ||
| ['Enter'], | ||
| isActive && !menuOpen, | ||
| handleActivate, | ||
| true, | ||
| '.c__tree-view', | ||
| ); | ||
|
|
Collaborator
There was a problem hiding this comment.
I don't think you need it anymore, this commit (suitenumerique/ui-kit@c121fdd#diff-69b4765cf5a180b5d5c2157eb0132487a6c0b7b7fb1dc379250ce110ac162e2eR27) adds onKeyDown, so here you can add directly what you need now.
You have to bump to the last ui-kit version though.
Collaborator
Author
There was a problem hiding this comment.
has talk together, waiting for updates on your side because change @gouvfr-lasuite/ui-kit": "0.18.4" to .5 or .6 seems to break
Ovgodd
force-pushed
the
fix/a11y-emoji-picker-focus-and-enter
branch
3 times, most recently
from
1955c20 to
5e197f3
Compare
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Ovgodd
force-pushed
the
fix/a11y-emoji-picker-focus-and-enter
branch
from
5e197f3 to
2560f59
Compare
Ovgodd
force-pushed
the
fix/a11y-emoji-picker-focus-and-enter
branch
from
1e0c43c to
0893d19
Compare
AntoLC
force-pushed
the
fix/a11y-emoji-picker-focus-and-enter
branch
from
0893d19 to
1239a99
Compare
Ovgodd
force-pushed
the
fix/a11y-emoji-picker-focus-and-enter
branch
3 times, most recently
from
7c0183c to
45bb502
Compare
Ovgodd
force-pushed
the
fix/a11y-emoji-picker-focus-and-enter
branch
from
cdcb6e6 to
4e990b0
Compare
ensures subdoc opens and emoji picker focus on input Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
fix/a11y-emoji-picker-focus-and-enter
branch
from
4e990b0 to
68df717
Compare
AntoLC
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve keyboard accessibility when opening the emoji picker
by focusing the input field automatically. Also fix keyboard interaction with
subdocuments using the Enter key.
Proposal
Automatically place focus on the search input when the emoji picker opens.
Additionally, ensure that pressing Enter correctly selects subdocuments,
improving keyboard usability.