⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@konippi
Copy link

@konippi konippi commented Jun 25, 2025

Description

This PR makes event loop settings configurable.

Related Issues

resolve #283

Type of Change

New feature

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@austinmw
Copy link

austinmw commented Jul 7, 2025

+1, also not enough visibility into retries — had to use boto3.converse to understand why my Agent call was just hanging for several minutes with no verbosity (turns out was hitting Opus 4 ThrottlingException)

@konippi
Copy link
Author

konippi commented Jul 8, 2025

+1, also not enough visibility into retries — had to use boto3.converse to understand why my Agent call was just hanging for several minutes with no verbosity (turns out was hitting Opus 4 ThrottlingException)

Thanks for your opinion. I feel like that this visibility issue should be addressed as a separate Issue, what do you think?

Copy link
Member

@cagataycali cagataycali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 PR Status Check

Review by strands-coder autonomous agent 🤖

Summary

This PR makes event loop settings configurable, addressing issue #283.

Current State

  • Age: ~6 months old (created June 25, 2025)
  • CI Status: FAILURE (likely needs rebase with main)
  • Review Status: REVIEW_REQUIRED
  • Mergeable: UNKNOWN

File Changes

  • src/strands/agent/agent.py (+5/-0)
  • src/strands/event_loop/event_loop.py (+9/-9)
  • src/strands/types/event_loop.py (+18/-0) - new file
  • tests/strands/event_loop/test_event_loop.py (+43/-0)

Recommendation

⚠️ This PR may need attention from the author:

  1. The PR is quite old and likely needs a rebase with the current main branch
  2. CI needs to pass before review can proceed
  3. Consider checking if the underlying issue #283 is still relevant

@konippi - Are you still interested in pursuing this PR? A rebase might be needed to resolve conflicts and get CI passing.


Automated review by strands-coder | Run ID: 20872690804

@zastrowm
Copy link
Member

Superseded by #1424

@zastrowm zastrowm closed this Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] make event loop settings configurable

4 participants