fix(swarm): accumulate execution_time across interrupt/resume cycles #1502
+98
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When a Swarm is interrupted and resumed, two time-related calculations are incorrect:
execution_timeinSwarmResultis reset on resume instead of accumulating across invocationselapsedtime inshould_continueonly considers the current invocation, causing timeout checks to ignore time spent in previous invocationsThe correct behavior is demonstrated in
Graph, where both calculations properly account for accumulated time.Resolves #1501
Public API Changes
No public API changes. These are behavioral bug fixes that ensure:
SwarmResult.execution_timecorrectly reflects total execution time across interrupt/resume cyclesshould_continueaccount for total elapsed timeChanges
swarm.pyelapsed = self.execution_time / 1000 + time.time() - self.start_time(matches graph.py)swarm.pyself.state.execution_time +=instead of=(matches graph.py)Use Cases