-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix(random): remove duplicate export metadata causing ESM bundle failures #9713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(random): remove duplicate export metadata causing ESM bundle failures #9713
Conversation
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Removed 'ndarray' export from the module exports. Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Coverage Report
The above coverage report was generated for the changes in this PR. |
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
|
@SuYaSh-PaThAk04 Thank you for your interest. However, this isn't the fix that is wanted here. What would actually be wanted is to fix the upstream issue so that "duplicate" symbols are de-duped. As such, I will close this PR. |
Thankyou @kgryte for your review .Would you be able to point me to the part of the toolchain where inferred ESM exports are collected? I’m happy to a contribute a fix there. |
Resolves #8864 .
Description
This PR fixes ESM bundle failures caused by duplicate
ndarrayexports.The// exports:metadata comment caused bundle-action to generate named exports which duplicated those inferred fromsetReadOnly(...)property definitions. Removing the redundant export metadata resolves the issue without changing the public API.This pull request:
randomrepository #8864Related Issues
This pull request has the following related issues:
randomrepository #8864Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers