⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@SuYaSh-PaThAk04
Copy link
Contributor

@SuYaSh-PaThAk04 SuYaSh-PaThAk04 commented Jan 12, 2026

Resolves #8864 .

Description

This PR fixes ESM bundle failures caused by duplicate ndarray exports.The // exports: metadata comment caused bundle-action to generate named exports which duplicated those inferred from setReadOnly(...) property definitions. Removing the redundant export metadata resolves the issue without changing the public API.

This pull request:

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Removed 'ndarray' export from the module exports.

Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 12, 2026
Signed-off-by: Suyash Pathak <[email protected]>
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 12, 2026

Coverage Report

Package Statements Branches Functions Lines
random/strided/arcsine $\color{green}293/293$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}293/293$
$\color{green}+0.00%$
random/strided/bernoulli $\color{green}181/181$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}0/0$
$\color{green}+0.00%$
$\color{green}181/181$
$\color{green}+0.00%$
random/strided/beta $\color{green}293/293$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}293/293$
$\color{green}+0.00%$
random/strided/betaprime $\color{green}293/293$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}293/293$
$\color{green}+0.00%$
random/strided/chi $\color{green}181/181$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}0/0$
$\color{green}+0.00%$
$\color{green}181/181$
$\color{green}+0.00%$
random/strided/chisquare $\color{green}181/181$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}0/0$
$\color{green}+0.00%$
$\color{green}181/181$
$\color{green}+0.00%$
random/strided/cosine $\color{green}294/294$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}294/294$
$\color{green}+0.00%$
random/strided/discrete-uniform $\color{green}293/293$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}293/293$
$\color{green}+0.00%$
random/strided/exponential $\color{green}181/181$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}0/0$
$\color{green}+0.00%$
$\color{green}181/181$
$\color{green}+0.00%$
random/strided/gamma $\color{green}293/293$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}293/293$
$\color{green}+0.00%$
random/strided/geometric $\color{green}181/181$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}0/0$
$\color{green}+0.00%$
$\color{green}181/181$
$\color{green}+0.00%$
random/strided/invgamma $\color{green}294/294$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}294/294$
$\color{green}+0.00%$
random/strided/lognormal $\color{green}293/293$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}293/293$
$\color{green}+0.00%$
random/strided/minstd-shuffle $\color{green}342/342$
$\color{green}+0.00%$
$\color{green}15/15$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}342/342$
$\color{green}+0.00%$
random/strided/minstd $\color{green}341/341$
$\color{green}+0.00%$
$\color{green}15/15$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}341/341$
$\color{green}+0.00%$
random/strided/mt19937 $\color{green}341/341$
$\color{green}+0.00%$
$\color{green}15/15$
$\color{green}+0.00%$
$\color{green}4/4$
$\color{green}+0.00%$
$\color{green}341/341$
$\color{green}+0.00%$
random/strided/normal $\color{green}293/293$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}293/293$
$\color{green}+0.00%$
random/strided/poisson $\color{green}181/181$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}0/0$
$\color{green}+0.00%$
$\color{green}181/181$
$\color{green}+0.00%$
random/strided/randu $\color{green}196/196$
$\color{green}+0.00%$
$\color{green}8/8$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}196/196$
$\color{green}+0.00%$
random/strided/rayleigh $\color{green}181/181$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}0/0$
$\color{green}+0.00%$
$\color{green}181/181$
$\color{green}+0.00%$
random/strided/t $\color{green}181/181$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}0/0$
$\color{green}+0.00%$
$\color{green}181/181$
$\color{green}+0.00%$
random/strided/uniform $\color{green}293/293$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}293/293$
$\color{green}+0.00%$
random/strided/weibull $\color{green}293/293$
$\color{green}+0.00%$
$\color{green}19/19$
$\color{green}+0.00%$
$\color{green}3/3$
$\color{green}+0.00%$
$\color{green}293/293$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
@kgryte
Copy link
Member

kgryte commented Jan 13, 2026

@SuYaSh-PaThAk04 Thank you for your interest. However, this isn't the fix that is wanted here. What would actually be wanted is to fix the upstream issue so that "duplicate" symbols are de-duped. As such, I will close this PR.

@kgryte kgryte closed this Jan 13, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 13, 2026
@kgryte kgryte added the Invalid Invalid question, issue, or pull request. label Jan 13, 2026
@SuYaSh-PaThAk04
Copy link
Contributor Author

@SuYaSh-PaThAk04 Thank you for your interest. However, this isn't the fix that is wanted here. What would actually be wanted is to fix the upstream issue so that "duplicate" symbols are de-duped. As such, I will close this PR.

Thankyou @kgryte for your review .Would you be able to point me to the part of the toolchain where inferred ESM exports are collected? I’m happy to a contribute a fix there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Invalid Invalid question, issue, or pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: bundles are failing to build in the standalone random repository

3 participants