-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add stats/base/dists/wald/cdf
#9709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
Given that the CI error is not due to changes in this PR will go ahead and open it for review!! |
| z = sqrt( lambda / x ); | ||
|
|
||
| // Φ(a) = 0.5 * erfc( -a / sqrt( 2 ) ) | ||
| t1 = 0.5 * erfc( ( -z * ( ( x / mu ) - 1.0 ) ) / sqrt( 2.0 ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could have used stats/base/dists/normal/cdf but while writing the C implementation using normal_cdf into the equation causes discrepancy in the return values.
| y = mycdf( 8.0 ); | ||
| // returns ~0.999 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throws an error if 0.998 is rounded of to 1.000 so used this instead!!
Planeshifter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a bunch of comments. Thanks!
lib/node_modules/@stdlib/stats/base/dists/wald/cdf/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/wald/cdf/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/wald/cdf/test/test.factory.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/wald/cdf/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/stats/base/dists/wald/cdf/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
|
@Planeshifter Updated the changes. But, benchmarks do seem to fail but runs clean locally. |

Progresses #209.
Description
This pull request:
stats/base/dists/wald/cdfRelated Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers