⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@Neerajpathak07
Copy link
Member

Progresses #8755

Description

What is the purpose of this pull request?

This pull request:

  • Migrates utils/deep-set to object/deep-set

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

This commit removes the `deepSet` symbol from the `@stdlib/utils`
namespace due to a package migration.

BREAKING CHANGE: remove `deepSet`

To migrate, users should access the same symbol via the
`@stdlib/object` namespace.

Ref: stdlib-js#8755
This commit removes `@stdlib/utils/deep-set` in favor of
`@stdlib/object/deep-set`.

BREAKING CHANGE: remove `utils/deep-set`

To migrate, users should update their require/import paths to use
`@stdlib/object/deep-set` which provides the same API and implementation.

Ref: stdlib-js#8755
@Neerajpathak07 Neerajpathak07 added the release: Major Breaking change requiring a new major release. label Jan 11, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 11, 2026

Coverage Report

Package Statements Branches Functions Lines
assert/deep-has-own-property $\color{green}438/438$
$\color{green}+100.00%$
$\color{green}47/47$
$\color{green}+100.00%$
$\color{green}6/6$
$\color{green}+100.00%$
$\color{green}438/438$
$\color{green}+100.00%$
assert/deep-has-property $\color{green}454/454$
$\color{green}+100.00%$
$\color{green}47/47$
$\color{green}+100.00%$
$\color{green}6/6$
$\color{green}+100.00%$
$\color{green}454/454$
$\color{green}+100.00%$
namespace/alias2pkg $\color{green}95/95$
$\color{green}+100.00%$
$\color{green}7/7$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}95/95$
$\color{green}+100.00%$
namespace $\color{red}39324/39427$
$\color{green}+99.74%$
$\color{green}112/112$
$\color{green}+100.00%$
$\color{red}2/11$
$\color{green}+18.18%$
$\color{red}39324/39427$
$\color{green}+99.74%$
namespace/pkg2alias $\color{green}100/100$
$\color{green}+100.00%$
$\color{green}10/10$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}100/100$
$\color{green}+100.00%$
namespace/pkg2related $\color{green}100/100$
$\color{green}+100.00%$
$\color{green}10/10$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}100/100$
$\color{green}+100.00%$
namespace/pkg2standalone $\color{green}95/95$
$\color{green}+100.00%$
$\color{green}7/7$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}95/95$
$\color{green}+100.00%$
namespace/standalone2pkg $\color{green}95/95$
$\color{green}+100.00%$
$\color{green}7/7$
$\color{green}+100.00%$
$\color{green}1/1$
$\color{green}+100.00%$
$\color{green}95/95$
$\color{green}+100.00%$
object/deep-get $\color{green}414/414$
$\color{green}+100.00%$
$\color{green}44/44$
$\color{green}+100.00%$
$\color{green}6/6$
$\color{green}+100.00%$
$\color{green}414/414$
$\color{green}+100.00%$
utils/deep-pluck $\color{green}285/285$
$\color{green}+100.00%$
$\color{green}25/25$
$\color{green}+100.00%$
$\color{green}3/3$
$\color{green}+100.00%$
$\color{green}285/285$
$\color{green}+100.00%$
utils $\color{red}42617/58139$
$\color{green}+73.30%$
$\color{red}713/753$
$\color{green}+94.69%$
$\color{red}22/480$
$\color{green}+4.58%$
$\color{red}42617/58139$
$\color{green}+73.30%$

The above coverage report was generated for the changes in this PR.

@Neerajpathak07
Copy link
Member Author

Given that lint errors are not due to changes in this PR I'll go ahead and open this for review

@Neerajpathak07 Neerajpathak07 marked this pull request as ready for review January 11, 2026 06:21
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 11, 2026
@Planeshifter
Copy link
Member

Found a couple of issues during review:

1. Missing update to alias2standalone/data/data.csv

The file lib/node_modules/@stdlib/namespace/alias2standalone/data/data.csv wasn't updated. Line 1588 still has:

deepSet,"@stdlib/utils-deep-set"

This should be updated to:

deepSet,"@stdlib/object-deep-set"

2. Pre-existing typo in docs/repl.txt (optional fix)

At line 70 in lib/node_modules/@stdlib/object/deep-set/docs/repl.txt, there's a pre-existing typo that says "Deep get function." but should be "Deep set function." since this is the return value description for deepSet.factory. Good opportunity to fix it while the file is being moved.

@Neerajpathak07
Copy link
Member Author

@Planeshifter Thanks for flagging this Wil close this PR Nad create 2 new ones addressing both the changes

@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 11, 2026
@kgryte
Copy link
Member

kgryte commented Jan 11, 2026

@Planeshifter Your comments are not relevant to this PR. Please read https://github.com/stdlib-js/stdlib/blob/develop/docs/contributing/moving_packages.md.

  1. This PR should not be updating databases, as described in the guide. The reason is merge conflicts. The databases are eventually made consistent during the automated "update REPL databases" workflow.
  2. Many of these packages have various things needing to be fixed. Those should be addressed in follow-up PRs; otherwise, we are now mixing concerns and imposing an additional review burden.

I suggest not using AI code reviews on the migration PRs that Neeraj is working on.

I am reopening this PR.

@kgryte kgryte reopened this Jan 11, 2026
@kgryte
Copy link
Member

kgryte commented Jan 11, 2026

@Neerajpathak07 Once merged, you can submit a PR fixing the typo in object/deep-set.

@kgryte kgryte added the Needs Review A pull request which needs code review. label Jan 11, 2026
@Neerajpathak07
Copy link
Member Author

@kgryte That works as well!

@Neerajpathak07
Copy link
Member Author

@kgryte can we land this in!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review A pull request which needs code review. release: Major Breaking change requiring a new major release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants