Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue preventing passkeys from being created.
Problem
The
web-auth/webauthn-libpackage recently changed what is returned by theassertionResponseValidator->check()method.It previously returned a
PublicKeyCredentialSourceinstance but it now returns aCredentialRecordinstance, causing a type error in our code.Solution
This PR fixes it by accepting any object (as
CredentialRecordonly exists in5.3.x) and converting theCredentialRecordto what we're expecting.These changes are part of the package's
5.3.xbranch which is yet to be tagged, but seems to be used when creating new Statamic sites.An alternative solution would be to pin the package to
5.2.xand handle the necessary changes after5.3.xhas been tagged.Fixes #13561