⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Batch #18 of #2285: Vector(ize) error code removal -- LAST ErrorCodeV1 entries!#2368

Merged
tatu-at-datastax merged 12 commits intomainfrom
tatu/2285-errorv1-removal-18
Feb 6, 2026
Merged

Batch #18 of #2285: Vector(ize) error code removal -- LAST ErrorCodeV1 entries!#2368
tatu-at-datastax merged 12 commits intomainfrom
tatu/2285-errorv1-removal-18

Conversation

@tatu-at-datastax
Copy link
Contributor

What this PR does:

Converts some more ErrorCodeV1 entries

Which issue(s) this PR fixes:
Part of #2285

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax self-assigned this Feb 2, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

📉 Unit Test Coverage Delta vs Main Branch

Metric Value
Main Branch 50.33%
This PR 50.06%
Delta 🔴 -0.27%
⚠️ Coverage decreased

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Unit Test Coverage Report

Overall Project 50.06% -0.06% 🍏
Files changed 42.86%

File Coverage
SchemaException.java 100% 🍏
InsertCollectionOperation.java 94.89% 🍏
QueryBuilder.java 94.57% -1.24%
FindCollectionOperation.java 80.16% -0.54%
SimilarityFunction.java 59.18% -4.08%
FindEmbeddingProvidersCommandResolver.java 55% 🍏
CreateCollectionCommandResolver.java 0% -4.38%
ValidateCredentials.java 0% -12.33%
JsonApiException.java 0% -3.83%
ErrorCodeV1.java 0% 🍏

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

📉 Integration Test Coverage Delta vs Main Branch (dse69-it)

Metric Value
Main Branch 70.69%
This PR 70.43%
Delta 🔴 -0.27%
⚠️ Coverage decreased

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Integration Test Coverage Report (dse69-it)

Overall Project 70.43% -0.05% 🍏
Files changed 43.88%

File Coverage
SchemaException.java 100% 🍏
CreateCollectionCommandResolver.java 97.7% -1.02% 🍏
InsertCollectionOperation.java 91.91% -1.7%
FindCollectionOperation.java 88.8% -0.54%
SimilarityFunction.java 82.99% -4.08%
QueryBuilder.java 80.93% -1.24%
FindEmbeddingProvidersCommandResolver.java 80% -20%
ValidateCredentials.java 8.22% -12.33%
JsonApiException.java 0% -3.83%
ErrorCodeV1.java 0% 🍏

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

📉 Integration Test Coverage Delta vs Main Branch (hcd-it)

Metric Value
Main Branch 72.44%
This PR 72.17%
Delta 🔴 -0.27%
⚠️ Coverage decreased

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2026

Integration Test Coverage Report (hcd-it)

Overall Project 72.17% -0.05% 🍏
Files changed 43.88%

File Coverage
SchemaException.java 100% 🍏
CreateCollectionCommandResolver.java 97.95% -1.02% 🍏
FindCollectionOperation.java 94.74% -0.54%
InsertCollectionOperation.java 94.68% -1.7%
QueryBuilder.java 90.08% -1.24%
SimilarityFunction.java 82.99% -4.08%
FindEmbeddingProvidersCommandResolver.java 80% -20%
ValidateCredentials.java 8.22% -12.33%
JsonApiException.java 0% -3.83%
ErrorCodeV1.java 0% 🍏

@tatu-at-datastax tatu-at-datastax changed the title Batch #18 of #2285: Vector(ize) code removal Batch #18 of #2285: Vector(ize) error code removal Feb 2, 2026
@tatu-at-datastax tatu-at-datastax changed the title Batch #18 of #2285: Vector(ize) error code removal Batch #18 of #2285: Vector(ize) error code removal -- LAST ErrorCodeV1 entries! Feb 3, 2026
@tatu-at-datastax tatu-at-datastax marked this pull request as ready for review February 3, 2026 19:13
@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner February 3, 2026 19:13
Copy link
Contributor

@Hazel-Datastax Hazel-Datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question: can't we remove ErrorCodeV1 and JsonApiException? Or it will be in a separate PR?

@tatu-at-datastax
Copy link
Contributor Author

LGTM, just one question: can't we remove ErrorCodeV1 and JsonApiException? Or it will be in a separate PR?

Yes, separate PR.

@tatu-at-datastax tatu-at-datastax merged commit f4f5507 into main Feb 6, 2026
3 checks passed
@tatu-at-datastax tatu-at-datastax deleted the tatu/2285-errorv1-removal-18 branch February 6, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants