Small changes for okio consistency #3498
Open
+9
−122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is typealiased by okio for JVM classes, so should be binary/api
compatible on JVM (the only one that cared about it).
This is also pretty standard for the rest of wire-runtime:
```
$ rg "import okio.IOEx" wire-runtime | wc
19 38 1790
```
Okio's closeable had the same signature so we're good to use it in commonMain. Moved the specific docs to the interface level to avoid needing to override the method just to doc it here, and avoid having to change the .api file.
Like MessageSink before it, we can reuse okio's closeable as it has the same signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks off a few quick places where okio was not being used in favor of platform-specific calls which okio wraps which can be taken advantage of.
Wire uses/exposes okio pretty frequently so its probably safe to assume these were just oversights or legacy reasons nobody has cared to change themselves.