fix(compiler): prevent schema parse failures by ignoring psql meta commands#4082
Open
andrewmbenton wants to merge 1 commit intomainfrom
Open
fix(compiler): prevent schema parse failures by ignoring psql meta commands#4082andrewmbenton wants to merge 1 commit intomainfrom
andrewmbenton wants to merge 1 commit intomainfrom
Conversation
dosubot
bot
added
size:S
|
Can this please be merged? It's a blocking issue with Postgres 17. @kyleconroy |
gbarr
reviewed
Oct 4, 2025
| var lines []string | ||
| for s.Scan() { | ||
| line := s.Text() | ||
| if strings.HasPrefix(line, `\`) { |
There was a problem hiding this comment.
This seems a little aggressive to remove all lines that begin with \. The following is valid SQL, but would be broken by this fix
SELECT E'
\x61 b c
';
I don't think pg_dump would create such a statement but hand written SQL could.
I would suggest that the fix only exclude lines starting with \restrict and \unrestrict
|
Bump. Can we get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is kind of a lazy quick-and-dirty implementation that doesn't attempt to consolidate some duplicate line parsing that we do during migration removal and just sticks a func right in the package that handles file parsing for all engines, even though this line filter only applies to postgresql.
Happy to revise if there's a better place to put this.
Resolves #4065