Open
Conversation
Author
|
currently, base behavior works but mixing params like so: -- name: ListAuthorsColumnSortDirection :many
SELECT * FROM authors
WHERE id > ?
ORDER BY
CASE
WHEN @order_by = 'asc' THEN name
END ASC,
CASE
WHEN @order_by = 'desc' OR @order_by IS NULL THEN name
END DESC;produces this incorrect output (question marks in CASE clauses should instead be same variable) -- name: ListAuthorsColumnSortDirection :many
SELECT id, name, bio FROM authors
WHERE id > ?
ORDER BY
CASE
WHEN ? = 'asc' THEN name
END ASC,
CASE
WHEN ? = 'desc' OR ? IS NULL THEN name
END DESCthis can still be worked around by using named params in this case. |
ORDER BY clause in sqliteORDER BY arg parsing in sqlite
|
How can we get this PR merged? I'm currently running into this issue :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sqlccurrently doesn't handle boundORDER BYclauses in sqlite, nor does it have tests for this behavior. This PR attempts for rectify this. Closes #3788.