Open
Conversation
Contributor
Author
|
I forgot to commit the |
Owner
|
I appreciate these kinds of PRs, even if I don't jump on them. As its job is especially narrow, the only reasons to update the SFX program is for performance or if it's unpacking improperly due to a bug, and so it's possible I may never update it. But I like that the option is here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similarly to PR 182, I haven't yet had the opportunity to test the changes, but I thought it would be preferable to open to open the PR early. I'll test this whenever I'll have an opportunity.