Implement LeftSemigroupIdeal and RightSemigroupIdeal#1009
Open
Jun2M wants to merge 45 commits intosemigroups:mainfrom
Open
Implement LeftSemigroupIdeal and RightSemigroupIdeal#1009Jun2M wants to merge 45 commits intosemigroups:mainfrom
Jun2M wants to merge 45 commits intosemigroups:mainfrom
Conversation
Number of arguments error resolved
Number of arguments error resolved
gap/ideals/ideals.gd
Outdated
| DeclareGlobalFunction("SemigroupIdeal"); | ||
| DeclareGlobalFunction("LeftSemigroupIdeal"); | ||
| DeclareGlobalFunction("RightSemigroupIdeal"); | ||
| DeclareGlobalFunction("AnySemigroupIdealInputParsing"); |
Collaborator
There was a problem hiding this comment.
Suggested change
| DeclareGlobalFunction("AnySemigroupIdealInputParsing"); | |
| DeclareGlobalFunction("AnySemigroupIdealInputParsing"); |
I'd suggest removing this from here, and instead doing
BindGlobal("_AnySemigroupIdealInputParsing", ...)
in the .gi file instead. Note also the _ in the name (either do this or just put the function into the record SEMIGROUPS, by doing:
SEMIGROUPS.AnySemigroupIdealInputParsing := function(...
again in the .gi file. Same goes for all of the "internal" functions that start with "Any"
gap/ideals/ideals.gi
Outdated
| InstallGlobalFunction(SemigroupIdeal, | ||
| function(arg...) | ||
| InstallGlobalFunction(AnySemigroupIdealInputParsing, | ||
| function(inputArgs) |
Collaborator
There was a problem hiding this comment.
Might be better to stick to arg... and whenever you want to call this function do:
CallFuncList(AnySemigroup..., arg);
this is like doing
AnySemigroup...(*arg)
in python
james-d-mitchell
requested changes
Mar 27, 2024
Collaborator
james-d-mitchell
left a comment
james-d-mitchell
left a comment
There was a problem hiding this comment.
A few very minor changes, and some tests and I'll be happy to merge this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pull request for #939.
Implements LeftSemigroupIdeal using a LeftMagmaIdeal and RightSemigroupIdeal as a RightMagmaIdeal.