Open
Conversation
Contributor
Author
|
@timtreis Naive question but I can't find where to download the artifacts to fix the tests, is this a permission issue or am I missing something? |
Member
|
@MeyerBender artifacts can be downloaded from the Actions page, for instance here: https://github.com/scverse/spatialdata-plot/actions/runs/20439596502?pr=526 Please find more info here: https://github.com/scverse/spatialdata-plot/blob/main/docs/contributing.md. Let me know if some questions are still open and not covered by the contribution guide. |
Contributor
Author
|
Thanks @LucaMarconato! With my current implementation, it is only possible to specify a colorlike, but not a feature (like "area"). I think it would be good to merge #497 first, and then add my code on top of that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses two previous issues with rendering labels:
outline_colorargument, similar to how they could inrender_shapes(), see Ability to change color of the border of labels #462render_labels, see Color leak whenoutline_alpha=1andfull_alpha=0#461Example code to see both changes in action: