⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@angrezichatterbox
Copy link
Member

Contributor checklist


Description

This PR adds flavours to the application. The Keyboard flavour would be the default and running the application would bring in the Keyboard application. However changing the flavour to conjugate would bring in the conjugate application which currently displays a sample application.

Related issue

@github-actions
Copy link

Thank you for the pull request! 💙

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the unit test, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

    • Tests may need to be reran as they're at times not deterministic
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox
Copy link
Member Author

@andrewtavis I had some queries related to adding in the Contributing and README changes which I will state here in a minute

@angrezichatterbox angrezichatterbox force-pushed the modularize-project-two-apps branch from b2609cc to f885429 Compare January 18, 2026 11:13
@angrezichatterbox
Copy link
Member Author

Currently I have made the flavours of the codebase hasn't been divided into the what's required for keyboard and conjugate app as I felt it would be better that would be done as would develop the conjugate application.

My idea would be to break the modules off the main app module once we have divided the codebase properly and then we would have a similar structure to FireFox and BitWarden.

This would make our work much easier as currently the entire existing main is being shared between the two apps for now as we slowly develop the application we would bring the components used by the individual application to their individual modules.

My idea is to merge this in and then I would like to bring in and then create an issue on a roadmap for this as we wouldn't forget this.

As for the contribution and other guidelines should I add a detailed description of it or should I just add a discrete description and then link the official docs.

@angrezichatterbox
Copy link
Member Author

The tests failed as we have to change the workflow file a bit. I will do that in a moment.

@angrezichatterbox
Copy link
Member Author

To change flavour. We have to click on the top bar button of Build and then select the option select build variant and then choose the variant we would like.

@andrewtavis
Copy link
Member

Thanks for the PR, @angrezichatterbox! Let's bring in #536 from @bhanu-dev82 and then we can move to bringing this in :) Let us know if you have any suggestions here as well, @bhanu-dev82 😊 Purpose of this is setting up the project such that we can maintain two projects in this repo, just so we do the initial work before the release of the keyboard app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants