Merged
Conversation
In old Ruby versions named parameters were just a fancy way to append a hash to the list of positional arguments. Newer Ruby versions treat named parameters as something more special and they are not forwarded by `*args` anymore.
When calling Warning.warn manually the first and last character would be trimmed from the warning message. Since the intention seems to have been to remove unneeded whitespace, we are now using strip instead of manually making a substring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update required Rubys to a maintained version. If anybody wants to use an older version of Ruby, they'll have to use an older version of structured warnings.
Cleaning up and removing older compatibility layers.
Also adding @NobodysNightmare's changes from #19 to improve cooperation with other gems overriding the default warning behavior.