Add plugin/marketplace commands #4

scaryrawr · 2026-01-15T20:20:05Z

Make it easier to manage marketplaces and plugins from outside of claude

- Export function to allow reuse in marketplace.ts - Use HOME env var with homedir() fallback for consistency

- Add enablePlugin() to add plugins to .construct.json - Add disablePlugin() to remove plugins from config - Add listEnabledPlugins() to show enabled plugins - Include comprehensive test coverage

- Add addMarketplace() to clone GitHub marketplaces - Add removeMarketplace() to unregister and optionally delete - Add updateMarketplace() to git pull updates - Add listMarketplaces() to show known marketplaces - Support GitHub URL and owner/repo shorthand formats - Include comprehensive test coverage

- Add 'construct plugin' command for plugin management - Add 'plugin enable/disable' for toggling plugins - Add 'plugin --list-enabled' flag - Add 'plugin marketplace' with add/remove/update/list subcommands - Add mutual exclusivity for update [name] and --all flags - Improve error messages for invalid subcommand usage

Document the plugin and marketplace commands including: - CLI usage examples - Implementation details - Error handling behavior - Testing strategy

Copilot

Pull request overview

This PR adds CLI commands for managing plugins and marketplaces externally from Claude, allowing users to enable/disable plugins and add/remove/update marketplaces via the command line.

Changes:

Added plugin management commands (enable, disable, list-enabled)
Added marketplace management commands (add, remove, update, list)
Extended CLI argument parsing to support nested subcommands using yargs

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/scanner.ts	Exported `getKnownMarketplacesPath()` and added HOME environment variable fallback
src/plugin.ts	New file implementing plugin enable/disable/list operations
src/plugin.test.ts	Comprehensive unit tests for plugin operations
src/marketplace.ts	New file implementing marketplace add/remove/update/list operations with git integration
src/marketplace.test.ts	Comprehensive unit tests for marketplace operations
src/cli.ts	Extended to support nested subcommands for plugin and marketplace management
plugin.md	Detailed documentation of the plugin management implementation
index.ts	Added command routing for new plugin and marketplace subcommands

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/plugin.ts

src/marketplace.ts

index.ts

Copilot · 2026-01-16T01:25:40Z

@scaryrawr I've opened a new pull request, #5, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-16T01:25:48Z

@scaryrawr I've opened a new pull request, #6, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 12 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T01:31:38Z

plugin.md

+```typescript
+export interface CliArgs {
+  command: "run" | "operator" | "plugin";
+  // ... existing fields ...
+  pluginSubcommand?: "enable" | "disable";
+  listEnabled?: boolean;
+  marketplaceSubcommand?: "list" | "add" | "remove" | "update";
+  pluginName?: string;
+  marketplaceTarget?: string;  // marketplace name or URL
+  updateAll?: boolean;
+}


The CliArgs interface documentation in plugin.md shows listEnabled as an optional boolean field, but the actual implementation in src/cli.ts uses listEnabledPlugins instead. This inconsistency could confuse developers reading the documentation.

@copilot open a new pull request to apply changes based on this feedback

index.ts

src/marketplace.ts

Copilot · 2026-01-16T01:31:39Z

src/plugin.ts

+  await saveConfig({
+    enabledPlugins: [...enabledPlugins, pluginName],
+    lastUsed: new Date().toISOString(),
+  });


The saveConfig call is missing proper error handling. If the file write fails (due to permissions or disk space issues), the config object will be partially modified in memory but not persisted. Consider wrapping this in a try-catch block and handling errors appropriately, or let the error propagate up to be handled by the caller in index.ts.

Copilot · 2026-01-16T01:31:39Z

src/cli.ts

+                .command(
+                  "update [name]",
+                  "Update marketplaces",
+                  (updateYargs) =>
+                    updateYargs
+                      .positional("name", {
+                        type: "string",
+                        conflicts: "all",
+                      })
+                      .option("all", {
+                        type: "boolean",
+                        alias: "a",
+                        description: "Update all git-based marketplaces",
+                        default: false,
+                      }),
+                  (args) => {
+                    command = "plugin";
+                    marketplaceSubcommand = "update";
+                    marketplaceTarget = args.name as string | undefined;
+                    updateAll = args.all as boolean;
+                  },


The yargs configuration uses "conflicts" between "name" positional and "all" option for the update command. However, the logic in index.ts (lines 62-73) doesn't handle the case where neither is provided gracefully before reaching the error message. Consider adding validation or documentation to make the expected behavior clearer.

src/plugin.ts

Copilot · 2026-01-16T01:31:40Z

src/marketplace.ts

+export async function updateAllMarketplaces(
+  paths?: MarketplacePaths,
+): Promise<void> {
+  const knownMarketplaces = await readKnownMarketplaces(paths);
+  const githubMarketplaces = Object.entries(knownMarketplaces).filter(
+    ([, info]) => info.source.source === "github",
+  );
+
+  for (const [name] of githubMarketplaces) {
+    await updateMarketplace(name, paths);
+  }
+
+  console.log(`Updated ${githubMarketplaces.length} marketplace(s)`);
+}


The updateAllMarketplaces function updates marketplaces sequentially but prints a summary message about the count after all updates complete. However, if any individual update fails (which calls process.exit(1) in runGitCommand), the summary message will never be printed. Consider either handling errors more gracefully or documenting this behavior.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-01-16T01:31:41Z

index.ts

+    if (
+      args.listEnabledPlugins &&
+      !args.pluginSubcommand &&
+      !args.marketplaceSubcommand
+    ) {
+      await listEnabledPlugins();
+      process.exit(0);
+    }


The conditional logic that checks for list-enabled only when no subcommands are present could lead to confusing behavior. If a user runs "construct plugin enable foo --list-enabled", the --list-enabled flag will be silently ignored. Consider either making these mutually exclusive in the yargs configuration or providing a warning when incompatible options are used together.

@copilot open a new pull request to apply changes based on this feedback

src/marketplace.ts

* Initial plan * fix: add check for empty marketplace list in updateAllMarketplaces Co-authored-by: scaryrawr <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: scaryrawr <[email protected]>

* Initial plan * fix: preserve all config fields when saving in plugin enable/disable Co-authored-by: scaryrawr <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: scaryrawr <[email protected]>

Copilot · 2026-01-16T01:36:19Z

@scaryrawr I've opened a new pull request, #7, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/marketplace.ts

src/plugin.ts

Copilot · 2026-01-16T01:37:59Z

@scaryrawr I've opened a new pull request, #8, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot · 2026-01-16T01:38:17Z

@scaryrawr I've opened a new pull request, #9, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <[email protected]>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-16T01:40:22Z

src/plugin.ts

+    return;
+  }
+
+  await saveConfig({


Duplicate await saveConfig({ statement on lines 45-47. Line 45 appears to be leftover code that should be removed. The try-catch block starting at line 46 is the intended implementation.

Suggested change

await saveConfig({

scaryrawr added 5 commits January 15, 2026 15:04

refactor(scanner): export getKnownMarketplacesPath and use HOME env var

7fea274

- Export function to allow reuse in marketplace.ts - Use HOME env var with homedir() fallback for consistency

feat(plugin): add enable/disable plugin management commands

c448d77

- Add enablePlugin() to add plugins to .construct.json - Add disablePlugin() to remove plugins from config - Add listEnabledPlugins() to show enabled plugins - Include comprehensive test coverage

docs: add plugin management implementation specification

c5b4e50

Document the plugin and marketplace commands including: - CLI usage examples - Implementation details - Error handling behavior - Testing strategy

Copilot AI review requested due to automatic review settings January 15, 2026 20:20

Copilot started reviewing on behalf of scaryrawr January 15, 2026 20:20 View session

Copilot AI reviewed Jan 15, 2026

View reviewed changes

src/plugin.ts Show resolved Hide resolved

src/plugin.ts Outdated Show resolved Hide resolved

src/marketplace.ts Show resolved Hide resolved

index.ts Outdated Show resolved Hide resolved

Copilot AI mentioned this pull request Jan 16, 2026

Preserve all config fields when updating plugin state #5

Merged

Copilot AI mentioned this pull request Jan 16, 2026

Add empty state handling to updateAllMarketplaces #6

Merged

Update index.ts

2801b2f

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings January 16, 2026 01:25

Copilot started reviewing on behalf of scaryrawr January 16, 2026 01:26 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Copilot AI and others added 2 commits January 15, 2026 20:33

Copilot AI review requested due to automatic review settings January 16, 2026 01:34

Copilot started reviewing on behalf of scaryrawr January 16, 2026 01:35 View session

Copilot AI mentioned this pull request Jan 16, 2026

Fix CliArgs interface documentation to match implementation #7

Closed

scaryrawr and others added 3 commits January 15, 2026 20:36

Update index.ts

bf5e5d1

Co-authored-by: Copilot <[email protected]>

Update src/marketplace.ts

263296c

Co-authored-by: Copilot <[email protected]>

Update src/plugin.ts

1b62e4d

Co-authored-by: Copilot <[email protected]>

Copilot AI reviewed Jan 16, 2026

View reviewed changes

src/marketplace.ts Show resolved Hide resolved

src/plugin.ts Outdated Show resolved Hide resolved

This was referenced Jan 16, 2026

Handle marketplace update failures gracefully in batch operations #8

Closed

Make --list-enabled mutually exclusive with enable/disable subcommands #9

Closed

Update src/plugin.ts

587e5d6

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings January 16, 2026 01:38

Copilot started reviewing on behalf of scaryrawr January 16, 2026 01:39 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

scaryrawr closed this Jan 16, 2026

Add plugin/marketplace commands #4

Add plugin/marketplace commands #4

Uh oh!

Conversation

scaryrawr commented Jan 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 16, 2026

Uh oh!

Copilot AI commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

scaryrawr Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

scaryrawr Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

scaryrawr Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 16, 2026

Uh oh!

Copilot AI commented Jan 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants