Upgrade jquery 4.0.0 by stefannibrasil · Pull Request #6687 · rubyforgood/casa

stefannibrasil · 2026-02-03T23:20:30Z

What github issue is this PR for, if any?

Resolves #6685
Related #6675

What changed, and why?

upgrades JQuery to 4.x
removes (seemingly) unused bootstrap-select dependency. The latest release was more than 4 years ago, and when I went to see how to make it work with JQuery 4.x, I realized we didn't seem to be using it
removes a console.log from a JS test

Screenshots please :)

I recorded a short screen video from my local setup with this branch:

CASA.JQuery.branc.mov

I also tested the forms by entering/selecting different dates and other fields and didn't notice anything broken by removing bootstrap-select but I am fairly new to the app, so let me know if I missed anything.

stefannibrasil · 2026-02-03T23:33:12Z

I will check CI errors tomorrow. Cannot reproduce them locally.

FireLemons · 2026-02-04T13:43:56Z

In the release notes,

jQuery source migrated to ES modules

It was a special day when the jQuery source on the main branch was migrated from AMD to ES modules. The jQuery source has always been published with jQuery releases on npm and GitHub, but could not be imported directly as modules without RequireJS, which was jQuery’s build tool of choice. We have since switched to Rollup for packaging jQuery and we do run all tests on the ES modules separately. This makes jQuery compatible with modern build tools, development workflows, and browsers through the use of <script type=module>.

We have jquery installed via node and it's only been accessible via a hack.
Can you undo the hack and use the standard imports?

The hacked way includes imports like

import './jQueryGlobalizer.js'
/* global $ */
/* global window */

This dependency is incompatible with JQuery 4.x. After searching for how it's used in the app, it looks like this dependency isn't being used and can be removed.

stefannibrasil · 2026-02-04T23:14:30Z

Thanks for the context @FireLemons I am working on that.

With JQuery 4, we can use standard imports instead of this globalizer.

This seems to not be necessary anymore but I need to test it. I tried importing it with require and import but it returns a `$ is not defined`.

stefannibrasil · 2026-02-05T03:56:24Z

@FireLemons what do you think of creating a follow up task for changing the import hacks? I tried doing that but I think it would be best to separate the upgrade from other changes.

compwron · 2026-02-05T17:46:21Z

This is very cool and if we can get the build green I would love to merge it :)

Copilot

Pull request overview

This PR upgrades jQuery from version 3.7.1 to 4.0.0, removes the unused bootstrap-select dependency, cleans up global variable comments, and consolidates jQuery globalization code. However, the PR has critical compatibility issues and removes essential functionality without replacement.

Changes:

Upgraded jQuery dependency from ^3.7.1 to ^4.0.0
Removed bootstrap-select package (unused in codebase)
Removed tooltip.js file and its import from application.js
Removed console.log statement from validated_form.js
Inlined jQueryGlobalizer.js content into application.js
Removed /* global $ */ and /* global window */ comments from multiple JavaScript files
Removed tooltip and followup-button click handler initialization from case_contact.js

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
package.json	Upgraded jQuery to 4.0.0 and removed bootstrap-select dependency
package-lock.json	Updated lockfile with jQuery 4.0.0 and created nested jQuery 3.7.1 for bootstrap-datepicker compatibility
app/javascript/application.js	Inlined jQuery globalization and removed tooltip.js import
app/javascript/jQueryGlobalizer.js	Deleted file (functionality moved to application.js)
app/javascript/src/*.js	Removed global variable comments and cleaned up code
app/javascript/src/validated_form.js	Removed debug console.log statement
app/javascript/src/case_contact.js	Removed global comments and deleted click handler registrations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T17:51:54Z

app/javascript/application.js

 require('./src/require_communication_preference')
 require('./src/select')
-require('./src/tooltip')
 require('./src/time_zone')


Removing the requirement for tooltip.js means that tooltips with data-toggle="tooltip" will no longer be automatically initialized. This file initialized all tooltips on page load. While dashboard.js still manually initializes tooltips in specific callbacks, other parts of the application that use data-toggle="tooltip" (such as app/views/case_contacts/form/details.html.erb line 285) will not have their tooltips initialized unless this functionality is restored. Consider either keeping the tooltip.js file requirement or ensuring tooltip initialization is handled elsewhere in the application (e.g., in application.js or through a Stimulus controller).

Copilot · 2026-02-05T17:51:55Z

app/javascript/application.js

+window.jQuery = jquery;
+window.$ = jquery;


Missing semicolons at the end of these statements. While JavaScript's automatic semicolon insertion will handle this, it's inconsistent with the coding style in the rest of the codebase where semicolons are used. For consistency, these lines should end with semicolons to match lines 13, 15-18, etc.

Copilot · 2026-02-05T17:51:55Z

app/javascript/src/case_contact.js

@@ -48,11 +45,6 @@ $(document).on('turbo:load', function () {
  })
 })



Critical functionality was removed from this file without replacement. The removed code block (between the turbo:load handler and this export statement) contained click handler registration for .followup-button elements that called displayFollowupAlert(). Without this handler, the "Make Reminder" buttons throughout the application (e.g., in app/views/case_contacts/_followup.html.erb) will not work. The displayFollowupAlert function still exists in this file but is now unused. System tests at spec/system/case_contacts/followups/create_spec.rb will fail. Either restore the click handler registration or implement this functionality through a Stimulus controller.

Suggested change

// Register click handler for "Make Reminder" buttons

$(document).on('click', '.followup-button', displayFollowupAlert)

stefannibrasil · 2026-02-05T20:53:33Z

hi @FireLemons and @compwron I would love to get this to the end but I am not there yet.

bootstrap-select is not compatible with jQuery 4.x. I tried a bunch of things but removing that dependency breaks the search/select on reports, and other forms using select2. It looks like we would need to swap bootstrap-select to something else first. The library itself hasn't been updated in 4 years, which wouldn't be a bad thing.

That said, if you have any other approaches that I am not seeing, let me know. I will take a break from this in the meantime to see if I can think of something else.

stefannibrasil requested review from FireLemons, compwron, elasticspoon and schoork as code owners February 3, 2026 23:20

github-actions bot added dependencies Pull requests that update a dependency file javascript for use by Github Labeler to mark pull requests that update Javascript code labels Feb 3, 2026

stefannibrasil changed the title ~~Sb upgrade jquery 4.0.0~~ Upgrade jquery 4.0.0 Feb 3, 2026

stefannibrasil added 3 commits February 4, 2026 14:43

Upgrade jquery dependency to 4.0.0

e151e39

Remove unused bootstrap-select dependency

49e8ad5

This dependency is incompatible with JQuery 4.x. After searching for how it's used in the app, it looks like this dependency isn't being used and can be removed.

Remove console.log from test

28999ee

stefannibrasil force-pushed the sb-upgrade-jquery-4.0.0 branch from b3d7ccd to 7c2a275 Compare February 5, 2026 02:10

github-actions bot added the Tests! 🎉💖👏 label Feb 5, 2026

stefannibrasil added 2 commits February 4, 2026 19:52

Remove JQuery globalizer

c463e14

With JQuery 4, we can use standard imports instead of this globalizer.

Remove tooltip require

bd2b90b

This seems to not be necessary anymore but I need to test it. I tried importing it with require and import but it returns a `$ is not defined`.

stefannibrasil force-pushed the sb-upgrade-jquery-4.0.0 branch from 7c2a275 to bd2b90b Compare February 5, 2026 02:55

linter

764579d

compwron requested a review from Copilot February 5, 2026 17:45

Copilot started reviewing on behalf of compwron February 5, 2026 17:46 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

stefannibrasil added 3 commits February 5, 2026 12:37

does it pass in CI?

ea07609

only tests fail but app works

a72ec7f

whaat

b024672

FireLemons marked this pull request as draft February 5, 2026 22:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade jquery 4.0.0#6687

Upgrade jquery 4.0.0#6687
stefannibrasil wants to merge 9 commits intorubyforgood:mainfrom
hexdevs:sb-upgrade-jquery-4.0.0

stefannibrasil commented Feb 3, 2026

Uh oh!

stefannibrasil commented Feb 3, 2026

Uh oh!

FireLemons commented Feb 4, 2026

Uh oh!

stefannibrasil commented Feb 4, 2026

Uh oh!

stefannibrasil commented Feb 5, 2026

Uh oh!

compwron commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

Copilot AI Feb 5, 2026

Uh oh!

stefannibrasil commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -48,11 +45,6 @@ $(document).on('turbo:load', function () {
		})
		})



	// Register click handler for "Make Reminder" buttons
	$(document).on('click', '.followup-button', displayFollowupAlert)

		window.jQuery = jquery;
		window.$ = jquery;

Uh oh!

Conversation

stefannibrasil commented Feb 3, 2026

What github issue is this PR for, if any?

What changed, and why?

Screenshots please :)

Uh oh!

stefannibrasil commented Feb 3, 2026

Uh oh!

FireLemons commented Feb 4, 2026

Uh oh!

stefannibrasil commented Feb 4, 2026

Uh oh!

stefannibrasil commented Feb 5, 2026

Uh oh!

compwron commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

stefannibrasil commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants