fix: copy_file skip files larger than 1GB (Fixes #4039)#4051
Open
IamHuskar wants to merge 1 commit intorr-debugger:masterfrom
Open
fix: copy_file skip files larger than 1GB (Fixes #4039)#4051IamHuskar wants to merge 1 commit intorr-debugger:masterfrom
IamHuskar wants to merge 1 commit intorr-debugger:masterfrom
Conversation
Author
|
Why is the MAP_SHARED check placed after copy_file? Line 1001 in 1f6d9a0 If the km region is MAP_SHARED, src.setTrace will be executed, but at that point, the file copying has already been completed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original PR at #4048 . should use rebase instead of merge.