Updated EntityCategory msg type with a new unknown type

[ayushgnv]

It would helpful to have a default category (value of 0) to account for entities that dont exist so we can differentiate between a Generic object that exists vs one that is not found.

[ayushgnv]

@adamdbrw any thoughts on this?

[adamdbrw]

My idea with the OBJECT category was that it encompasses these cases (as in, everything is an object).
What would be a way in which we get entity returned by our APIs but this entity actually does not exist? Could you give me some context to that?

[ayushgnv]

My idea with the OBJECT category was that it encompasses these cases (as in, everything is an object).

What would be a way in which we get entity returned by our APIs but this entity actually does not exist? Could you give me some context to that?

In GetEntityInfo, we return a result and EntityInfo. EntityInfo contains EntityCategory which can only be set as OBJECT and others. I think when a entity is not found rather than returning the default OBJECT with a error result, it would be cleaner for the user if EntityCategory had a field for UNKNOWN (or something similar) which is then returned with an error result.

[ayushgnv]

@peci1 @azeey any thoughts regarding this?

[peci1]

I don't think this is needed. When the result has error, the other fields have unspecified value and should not be examined at all.

[azeey]

I'd agree with @peci1. If the result is an error, the values in the other fields are undefined.