[v636][CPyCppyy] Work around non-instantiable std::span iterators in GCC 15
#20929
+148
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libstdc++ (GCC >= 15) implements `std::span::iterator` using a private nested tag type, which makes the iterator non-instantiable by CallFunc-generated wrappers (the return type cannot be named without violating access rules). To preserve correct Python iteration semantics, this commit suggests to replace `begin()`/`end()` for `std::span` to return a custom pointer-based iterator instead. This avoids relying on `std::span::iterator` while still providing a real C++ iterator object that CPyCppyy can also wrap and expose via `__iter__`/`__next__`. A unit test is implemented based on the reproducers provided in root-project#18837. Closes root-project#18837. (cherry picked from commit 598e301)
guitargeek
merged commit edd69e4
into
root-project:v6-36-00-patches
19 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #20891 as requested by @sponce