[HF] Prepare HistFactory for ROOT without implicit ownership #20922
Conversation
| TFile* file = new TFile("dataDriven.root", "RECREATE"); | ||
|
|
||
| TH1F* FlatHist = new TH1F("FlatHist","FlatHist", 2,0,2); | ||
| FlatHist->SetDirectory(file); |
There was a problem hiding this comment.
I don't get it yet 🙂 If you later explicitly write the histograms with file->WriteTObject(histo), why do you need to do SetDirectory(file) before?
There was a problem hiding this comment.
You indeed don't need it to write, but you do need it to destroy the histogram. Alternatively, you can of course take the ownership "manually".
There was a problem hiding this comment.
Let me do a solution that doesn't need SetDirectory
If implicit object ownership gets in TDirectories gets switched off, the example histograms need to be added to directories or written explicitly.
hageboeck
force-pushed
the
root7-ownership-6
branch
from
f5398dd to
4b5962e
Compare
git clang-format applied enough changes to make it worth formatting the entire file.
hageboeck
force-pushed
the
root7-ownership-6
branch
from
4b5962e to
f4a8d9b
Compare
guitargeek
left a comment
guitargeek
left a comment
There was a problem hiding this comment.
Awesome! As discussed also in private, I think this PR sets now a good precedent for how to write histogram objects to files.
Test Results 22 files 22 suites 3d 20h 55m 46s ⏱️ Results for commit f4a8d9b. |
2 participants
makeExample.CtutorialBy making the writes explicit, the tests become independent of gDirectory and whether or not histograms register themselves.