⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

[cmake] Unify Ninja builds #20917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bellenot wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[cmake] Unify Ninja builds #20917

bellenot wants to merge 2 commits into from

Conversation

@bellenot
Copy link
Member

@bellenot bellenot commented Jan 16, 2026

  • Don't exclude MSVC for the Ninja RESOURCE_LOCK
  • Fix a warning on Windows about unknown -fPIC compiler flag

@bellenot
[cmake] Unify Ninja builds
dc0765f 
- Don't exclude MSVC for the `Ninja` `RESOURCE_LOCK`
- Fix a warning on Windows about unknown `-fPIC` compiler flag
@bellenot bellenot self-assigned this Jan 16, 2026
@bellenot bellenot mentioned this pull request Jan 16, 2026
Merged
hahnjo
hahnjo approved these changes Jan 16, 2026
View reviewed changes
Copy link
Member

@hahnjo hahnjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Ninja changes LGTM

@github-actions
Copy link

github-actions bot commented Jan 16, 2026 •
edited
Loading

Test Results

    22 files      22 suites   3d 21h 24m 19s ⏱️
 3 812 tests  3 812 ✅ 0 💤 0 ❌
76 723 runs  76 723 ✅ 0 💤 0 ❌

Results for commit f28f212.

♻️ This comment has been updated with latest results.

guitargeek
guitargeek approved these changes Jan 16, 2026
View reviewed changes
Copy link
Contributor

@guitargeek guitargeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bellenot bellenot closed this Jan 19, 2026
@bellenot bellenot reopened this Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hahnjo hahnjo hahnjo approved these changes

@guitargeek guitargeek guitargeek approved these changes

@hageboeck hageboeck Awaiting requested review from hageboeck

Assignees

@bellenot bellenot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bellenot @hahnjo @guitargeek