Add CLI statement-timeout flag #1142
Open
+211
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
force-pushed
the
bg/expose-cli-timeout-flags
branch
4 times, most recently
from
a70b9f6 to
a265da1
Compare
River CLI Postgres commands had fixed session defaults and no explicit flag for statement timeout. For long-running migrations, callers either accepted the default or had to encode `statement_timeout` into the connection string. This could be difficult in deployed environments where i.e. a database connection string was shared with an application and the user did not want to accidentally affect timeouts for other processes using a shared connection string. This commit adds a root `--statement-timeout` flag and thread it through command bootstrapping into Postgres pool configuration. Statement timeout now uses explicit precedence: flag value first, then connection-string query parameter, then built-in default. `idle_in_transaction_session_timeout` keeps its existing behavior and remains URL/default driven. Values under 1ms would be truncated to 0 and are rejected as invalid.
bgentry
force-pushed
the
bg/expose-cli-timeout-flags
branch
from
a265da1 to
4a3e207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
River CLI Postgres commands had fixed session defaults and no explicit flag for statement timeout. For long-running migrations, callers either accepted the default or had to encode
statement_timeoutinto the connection string. This could be difficult in deployed environments where i.e. a database connection string was shared with an application and the user did not want to accidentally affect timeouts for other processes using a shared connection string.This commit adds a root
--statement-timeoutflag and thread it through command bootstrapping into Postgres pool configuration. Statement timeout now uses explicit precedence: flag value first, then connection-string query parameter, then built-in default.idle_in_transaction_session_timeoutkeeps its existing behavior and remains URL/default driven.