-
Notifications
You must be signed in to change notification settings - Fork 893
feat: update skill #2849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
feat: update skill #2849
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4 issues found across 7 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="skills/references/SENDING.md">
<violation number="1" location="skills/references/SENDING.md:34">
P2: Rule violated: **API Key Permission Check SDK Methods**
Add a reminder to verify production API keys have the required send permissions for these newly documented SDK send operations, as required by the API Key Permission Check SDK Methods rule.</violation>
</file>
<file name="skills/SKILL.md">
<violation number="1" location="skills/SKILL.md:269">
P2: Anchor elements should use `href`, not `src`, or the link won’t work. Update the example to use the correct attribute.</violation>
</file>
<file name="packages/react-email/src/utils/preview/hot-reloading/create-dependency-graph.spec.ts">
<violation number="1" location="packages/react-email/src/utils/preview/hot-reloading/create-dependency-graph.spec.ts:33">
P2: Rule violated: **No `should` in tests**
Test description contains “should”, which violates the “No `should` in tests” rule. Use a direct, declarative verb phrase instead.</violation>
<violation number="2" location="packages/react-email/src/utils/preview/hot-reloading/create-dependency-graph.spec.ts:43">
P2: Rule violated: **No `should` in tests**
Test description contains “should”, which violates the “No `should` in tests” rule. Use a direct, declarative verb phrase instead.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
packages/react-email/src/utils/preview/hot-reloading/create-dependency-graph.spec.ts
Outdated
Show resolved
Hide resolved
packages/react-email/src/utils/preview/hot-reloading/create-dependency-graph.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 2 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/react-email/src/utils/preview/hot-reloading/create-dependency-graph.spec.ts">
<violation number="1">
P2: Rule violated: **No `should` in tests**
Test description contains "should". Rewrite to a direct, declarative phrase (e.g., "has the right initial value for the dependency graph") to comply with the no-should-in-tests rule.</violation>
<violation number="2">
P2: Rule violated: **No `should` in tests**
Test description contains "should". Rewrite to a direct, declarative phrase (e.g., "resolves dependents when there are circular dependencies") to comply with the no-should-in-tests rule.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Co-authored-by: Gabriel Miranda <[email protected]>
Summary by cubic
Revamps the React Email docs to a Tailwind-first approach with clearer setup, usage, and sending guidance. Adds a dedicated sending guide and updates examples to use pixelBasedPreset; no runtime code changes.
New Features
Refactors
Written for commit 9bcbfed. Summary will update on new commits.