⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@cpenned
Copy link
Contributor

@cpenned cpenned commented Jan 16, 2026


Summary by cubic

Revamps the React Email docs to a Tailwind-first approach with clearer setup, usage, and sending guidance. Adds a dedicated sending guide and updates examples to use pixelBasedPreset; no runtime code changes.

  • New Features

    • Added references/SENDING.md with Resend (SDK and MCP), Nodemailer, SendGrid examples, and template upload steps.
    • Expanded SKILL.md with create-email setup, install/dev server/verify steps, Tailwind usage, rendering to HTML/plain text, and behavioral/styling best practices (safe variables, client limits, layout/dark mode, images, buttons).
  • Refactors

    • Rewrote references/COMPONENTS.md to Tailwind-first examples, added components list/import guidance, and clarified CodeBlock/Markdown props.
    • Updated references/I18N.md and references/PATTERNS.md to use Tailwind and pixelBasedPreset; removed inline styles.

Written for commit 9bcbfed. Summary will update on new commits.

@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2026

⚠️ No Changeset found

Latest commit: 9bcbfed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@cpenned cpenned requested a review from gabrielmfern January 16, 2026 20:20
@vercel
Copy link

vercel bot commented Jan 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
react-email Ready Ready Preview, Comment Jan 16, 2026 10:39pm
react-email-demo Ready Ready Preview, Comment Jan 16, 2026 10:39pm

Request Review

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 16, 2026

Open in StackBlitz

npm i https://pkg.pr.new/resend/react-email/@react-email/preview-server@2849
npm i https://pkg.pr.new/resend/react-email@2849

commit: f0a4414

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 issues found across 7 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="skills/references/SENDING.md">

<violation number="1" location="skills/references/SENDING.md:34">
P2: Rule violated: **API Key Permission Check SDK Methods**

Add a reminder to verify production API keys have the required send permissions for these newly documented SDK send operations, as required by the API Key Permission Check SDK Methods rule.</violation>
</file>

<file name="skills/SKILL.md">

<violation number="1" location="skills/SKILL.md:269">
P2: Anchor elements should use `href`, not `src`, or the link won’t work. Update the example to use the correct attribute.</violation>
</file>

<file name="packages/react-email/src/utils/preview/hot-reloading/create-dependency-graph.spec.ts">

<violation number="1" location="packages/react-email/src/utils/preview/hot-reloading/create-dependency-graph.spec.ts:33">
P2: Rule violated: **No `should` in tests**

Test description contains “should”, which violates the “No `should` in tests” rule. Use a direct, declarative verb phrase instead.</violation>

<violation number="2" location="packages/react-email/src/utils/preview/hot-reloading/create-dependency-graph.spec.ts:43">
P2: Rule violated: **No `should` in tests**

Test description contains “should”, which violates the “No `should` in tests” rule. Use a direct, declarative verb phrase instead.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com>
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="packages/react-email/src/utils/preview/hot-reloading/create-dependency-graph.spec.ts">

<violation number="1">
P2: Rule violated: **No `should` in tests**

Test description contains "should". Rewrite to a direct, declarative phrase (e.g., "has the right initial value for the dependency graph") to comply with the no-should-in-tests rule.</violation>

<violation number="2">
P2: Rule violated: **No `should` in tests**

Test description contains "should". Rewrite to a direct, declarative phrase (e.g., "resolves dependents when there are circular dependencies") to comply with the no-should-in-tests rule.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Co-authored-by: Gabriel Miranda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants