⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@msimberg
Copy link

@msimberg msimberg commented Jan 8, 2026

No description provided.

@vkarak vkarak self-requested a review January 12, 2026 20:36
@vkarak vkarak assigned vkarak and unassigned vkarak Jan 12, 2026
@vkarak vkarak changed the title Fix typo in RegressionMixin deprecation message [bugfix] Fix typo in RegressionMixin deprecation message Jan 12, 2026
@vkarak vkarak moved this to Todo in ReFrame Backlog Jan 12, 2026
@vkarak vkarak added this to the ReFrame 4.9.1 milestone Jan 12, 2026
@vkarak
Copy link
Contributor

vkarak commented Jan 12, 2026

This needs to be opened against master, since it's a bug fix and will be scheduled for 4.9.1.

@vkarak vkarak force-pushed the fix-regresssion-typo branch from 0270c46 to 7422200 Compare January 12, 2026 21:00
@vkarak vkarak changed the base branch from develop to master January 12, 2026 21:01
@vkarak
Copy link
Contributor

vkarak commented Jan 12, 2026

This needs to be opened against master, since it's a bug fix and will be scheduled for 4.9.1.

I've done it already and forced pushed to your branch.

Copy link
Contributor

@vkarak vkarak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-project-automation github-project-automation bot moved this from Todo to In Progress in ReFrame Backlog Jan 12, 2026
@vkarak vkarak enabled auto-merge January 12, 2026 21:02
@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.51%. Comparing base (becf314) to head (7422200).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3607      +/-   ##
==========================================
+ Coverage   91.26%   91.51%   +0.24%     
==========================================
  Files          62       62              
  Lines       13583    14640    +1057     
==========================================
+ Hits        12397    13398    +1001     
- Misses       1186     1242      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@msimberg
Copy link
Author

Thanks for the change @vkarak! Do I need to do anything to get those required checks to run?

@vkarak
Copy link
Contributor

vkarak commented Jan 13, 2026

Do I need to do anything to get those required checks to run?

Since we removed support for Python < 3.9, develop and master branches have different list of required tests. I suppose Github got confused since the PR was opened on develop and then changed to master. I will close and reopen the PR to retrigger the CI.

@vkarak vkarak closed this Jan 13, 2026
auto-merge was automatically disabled January 13, 2026 09:19

Pull request was closed

@github-project-automation github-project-automation bot moved this from In Progress to Done in ReFrame Backlog Jan 13, 2026
@vkarak vkarak reopened this Jan 13, 2026
@github-project-automation github-project-automation bot moved this from Done to In Progress in ReFrame Backlog Jan 13, 2026
@vkarak vkarak enabled auto-merge January 13, 2026 09:20
@vkarak vkarak merged commit e197ed3 into reframe-hpc:master Jan 13, 2026
69 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ReFrame Backlog Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants