⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@micheleRP
Copy link
Contributor

@micheleRP micheleRP commented Jan 12, 2026

TO MERGE AFTER 25.3.5 releases, probably Jan 16

This pull request adds documentation navigation entries for new role management commands in the security section. This helps users find and access information about role-related operations in the documentation.

  • Added a top-level entry for rpk-security-role and sub-entries for assigning, creating, deleting, describing, listing, and unassigning roles in modules/ROOT/nav.adoc.## Description

Resolves https://redpandadata.atlassian.net/browse/DOC-1727
Review deadline:

Page previews

rpk security role

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@micheleRP micheleRP requested a review from a team as a code owner January 12, 2026 18:12
@netlify
Copy link

netlify bot commented Jan 12, 2026

Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit b7f04ac
🔍 Latest deploy log https://app.netlify.com/projects/rp-cloud/deploys/6965397bcc097200086a7414
😎 Deploy Preview https://deploy-preview-483--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 12, 2026

📝 Walkthrough

Walkthrough

This change adds navigation references for RBAC role management documentation and secret-related documentation entries to the AsciiDoc navigation file. Seven new entries are added for role-related commands (role, assign, create, delete, describe, list, unassign), and two entries are added for secret-related commands (list, update). These entries are inserted within the existing Security section under the ACL and RBAC sequences.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • r-vasquez
  • kbatuigas
  • andresaristizabal
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly references the issue number (DOC-1727) and the main subject (rpk security role in Cloud), directly matching the PR's primary objective.
Linked Issues check ✅ Passed The PR adds navigation entries for role management commands (create, assign, delete, describe, list, unassign) in nav.adoc, directly addressing DOC-1727's requirement to document Cloud-exposed RPK role-management capabilities.
Out of Scope Changes check ✅ Passed All changes are limited to nav.adoc navigation entries for role management documentation, staying within the scope of DOC-1727's documentation objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description is mostly complete with an issue link, page preview reference, and proper checkbox selection, though the actual page preview URL is incomplete.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants