-
Notifications
You must be signed in to change notification settings - Fork 76
pyproject.toml: PEP 639 compatibility #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
You may want to add |
|
The default value of |
|
Two 👍, just waiting on a review from someone with merge privileges... |
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
Co-authored-by: Dimitri Papadopoulos Orfanos <3234522+DimitriPapadopoulos@users.noreply.github.com>
Co-authored-by: Dimitri Papadopoulos Orfanos <3234522+DimitriPapadopoulos@users.noreply.github.com>
4df8450 to
d4ca023
Compare
|
@mattip is this ready to merge now? |
|
Trying to close out old PRs, is this still wanted? |
|
I would like to see this PR merged. |
|
Would anyone with merge privileges still like to see this PR merged? |
|
Truthfully, I don't know enough about the various setuptools versions. Will this break older versions? |
|
This setting requires setuptools 77+. By requiring this in pyproject.toml, pip will ensure that a suitable version is available in the build environment. |
Newer versions support newer specifications, and drop support for deprecated (parts of) specifications. In this case, sometime in the near future table-type license definitions will cause setuptools to raise an exception on build Setuptools v77 requires Python 3.9+ |
|
There's no point trying to keep compatibility with older versions. From the Python Packaging User Guide:
The only constraint is that cffi must support the latest version of setuptools that supports the earliest version of Python supported by cffi. As already stated, setuptools 77.0.3 does support Python 3.9. |
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
While not affecting any decisions in this pull request, note the the quoted section of the packaging user guide is out of date (and I'm in the process of removing: pypa/packaging.python.org#1999). The reality is that the latest compatible versions of build dependencies (including backends like setuptools, and their dependencies like |
Reverts #199
Fixes #200
PEP 621 is superseded by PEP 639. The previous syntax is deprecated and will be removed in a future version of setuptools.
@Bluefissure @EpicWink @mattip