A few small cleanups #640
Merged
A few small cleanups #640
+39
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes it easier to see that `args` can't end up unbound.
Replaces #277. The extra try has no effect.
It actually adds measurable overhead here -- ~15% according to testing/benchmark.py (on Python 3.14).
RonnyPfannschmidt
approved these changes
Jan 11, 2026
Member
Author
|
The coverage changes are due to the de-indentation touch a bunch of lines. I'm not sure how to interpret the "!" lines in the codecov report but we have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is a small simplification.
The second commit is a rehash of #277 which I still think we should do, it shouldn't disturb any refactoring, I think it's just useless.
The third commit is a slightly ugly micro-optimization but which has a nice impact on the benchmarks so I think we should do it.