Conversation
webknjaz
left a comment
There was a problem hiding this comment.
The idea is initially interesting, but I have a better example.
Mimic these if you want to continue working on this PR: https://github.com/ansible/receptor/blob/794e4c402c7045091e111a3bfc97722a2af214ba/.github/workflows/reusable-nox.yml#L58-L64 / https://github.com/ansible/receptor/blob/794e4c402c7045091e111a3bfc97722a2af214ba/.github/workflows/pull_request.yml#L87-L120. Without the go or project-specific stuff, of course. Follow the naming conventions too.
The "module" should be named reusable-*. The conditionals should live outside that reusable module. The call to nox should be split into provisioning and execution.
Besides that, I'd rather have version bumps in a separate PR.
874318f to
c863690
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the CI workflows by updating GitHub Actions versions and introducing a reusable workflow pattern to reduce duplication. The changes update actions/checkout from v3 to v4, actions/setup-python from v4 to v5, and add pip caching configuration.
Key changes:
- Update GitHub Actions to newer versions with enhanced caching
- Refactor test workflow to use a reusable build workflow
- Add pip caching to improve build performance
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/translation.yml | Updates action versions and adds pip caching configuration |
| .github/workflows/test.yml | Refactors to use reusable workflow and splits build/linkcheck jobs |
| .github/workflows/build.yml | New reusable workflow for common build steps |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
📚 Documentation preview 📚: https://python-packaging-user-guide--1775.org.readthedocs.build/en/1775/