bricks/primehub: restore access to LPW3 and UART modules #456
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 1ccc277 introduced discrepancies between Essential and Prime hubs. Add back access to LWP3Device and UARTDevice classes.
Member
|
Thanks for taking the time to fix it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I was eager to try-out the latest firmware and its new connectivity capabilities, using my Prime hub in conjunction with Duplo train. Alas, I realized I could not connect anymore (e.g. with the code given in https://pybricks.com/project/control-the-duplo-train/). After some digging I saw that the refactoring introduced in commit 1ccc277 left-out some modules from the Prime hub, compared to the Essential one. I am unsure if this was intentional or not, since I was under the impression that the Prime hub could embed more features.
Hence a small pull request to sync both
mpconfigport.hfiles, hoping that it makes sense.