Open
Conversation
|
+1 |
1 similar comment
|
+1 |
|
Pull request is not the right way to go. See my pull request #8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When upgrading my app to Rails 3 I encountered an issue with collection_table escaping the generated content. I tried various ways of working around this, and none worked: (a) calling html_safe against each of the strings I passed to collection_table, (b) using <%=raw in the first line, and (c) putting each line into its own erb <%=raw %> line.
The solution that worked was to modify content_tag calls in table_helper to disable the escaping.
Here are some of the references I used:
http://stackoverflow.com/questions/3863844/rails-how-to-build-table-in-helper-using-content-tag/
http://asciicasts.com/episodes/204-xss-protection-in-rails-3/
http://railsdispatch.com/posts/security/
http://yehudakatz.com/2010/02/01/safebuffers-and-rails-3-0/