Adding proper error messages for Win32 shmop #20944
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add proper errno setting for all error paths in shmget() on Windows. Introduces tsrm_set_errno_from_win32_error() to map Windows error codes to POSIX errno values (EACCES, ENOMEM, EINVAL, EEXIST, ENOENT). This ensures that shmop_open() can provide meaningful error messages to users instead of "No error" when operations fail. Tests added to verify errno mapping for different error conditions.
Set errno for error conditions in shmdt() and shmctl(): - EINVAL for invalid segment address/key - Windows error mapping for UnmapViewOfFile failures - EINVAL for unknown shmctl commands This completes errno handling for all shmop system calls on Windows.
Add proper handle cleanup when marking shared memory segment for deletion. Previously, shmctl(IPC_RMID) only marked the segment by setting key to -1 but did not close the Windows file mapping handle, causing the segment to persist in the system. This led to errors when trying to reopen segments with the same key: - Segment remained accessible via OpenFileMapping() - But had key = -1, failing validation checks - Resulted in "Invalid argument" errors Now properly closes the handle, allowing Windows to destroy the named mapping object when no processes are attached, matching POSIX semantics where IPC_RMID marks segment for deletion. Fixes issue where shmop_open() with 'c' flag fails after shmop_delete().
Member
You should effectively never target a patch. If something needs to be included in a patch that is already branched, the commit will be cherry-picked by the release manager. So, if this fixes a bug and the patch isn't risky, you should target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current Win32 shmop implementation, messages like
This happens because the
errnovariable is not populated correctly on Win32.This change fixes the Win32 logic so that error messages roughly match the actual outcome. Unfortunately, it is still not perfect, as there is a case with differing segment sizes that is handled as an invalid descriptor.