⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@chavic
Copy link
Collaborator

@chavic chavic commented Feb 9, 2026

This work in progress adds C# bindings and implements tests following the pattern in the other languages

@coveralls
Copy link
Collaborator

coveralls commented Feb 9, 2026

Pull Request Test Coverage Report for Build 21824670262

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.263%

Totals Coverage Status
Change from base Build 21757410623: 0.0%
Covered Lines: 10238
Relevant Lines: 12296

💛 - Coveralls

@chavic chavic force-pushed the chavic/c-sharp-bindings branch from 7864f2a to b4799da Compare February 9, 2026 08:54
@chavic chavic force-pushed the chavic/c-sharp-bindings branch from b4799da to ae74db7 Compare February 9, 2026 12:14
@DanGould
Copy link
Contributor

DanGould commented Feb 9, 2026

BOOYEAH

I like the direction this is going.

<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is net8.0 the most common target? I'm very curious what the actual needs of a BTCpayServer plugin or Strike are, because I've dealt with incompatibility issue here, albeit years ago.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it can: https://blog.btcpayserver.org/btcpay-server-1-12-0/#upgrade-to-net-8. Strike is likely ahead because they don't need to support a bunch of open source stuff.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, any idea which specific runtime they're on?

I did a quick check beforehand to target the most common runtime right now...

Gonna look loser into the Strike repos specifically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants