-
Notifications
You must be signed in to change notification settings - Fork 79
Add C# language bindings for payjoin-ffi #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 21824670262Details
💛 - Coveralls |
7864f2a to
b4799da
Compare
b4799da to
ae74db7
Compare
|
BOOYEAH I like the direction this is going. |
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net8.0</TargetFramework> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is net8.0 the most common target? I'm very curious what the actual needs of a BTCpayServer plugin or Strike are, because I've dealt with incompatibility issue here, albeit years ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can: https://blog.btcpayserver.org/btcpay-server-1-12-0/#upgrade-to-net-8. Strike is likely ahead because they don't need to support a bunch of open source stuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, any idea which specific runtime they're on?
I did a quick check beforehand to target the most common runtime right now...
Gonna look loser into the Strike repos specifically
This work in progress adds C# bindings and implements tests following the pattern in the other languages