Listen for both HTTP and HTTPS #1316
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This satisfies trait bounds for AxumAcceptor in the next commit.
Add an `acme` feature flag and config section modeled after the payjoin-directory feature. This implementation uses `tokio-rustls-acme`'s AxumAcceptor following the example in https://github.com/FlorianUekermann/rustls-acme/blob/main/examples/low_level_axum.rs As a result the AcmeConfig differs slightly from the one in payjoin-directory to more closely reflect rustls-acme's AcmeConfig struct.
DanGould
force-pushed
the
service-multi-listener
branch
from
79bb0e4 to
62a1ce2
Compare
This allows us to fully rely on the payjoin-service without a reverse proxy. Without this change, It's not possible to support TLS bootstrapping and environments, like Bitcoin Core, which don't have TLS available.
Describe the service functions as standalone with acme or with reverse proxy TLS termination.
DanGould
force-pushed
the
service-multi-listener
branch
from
62a1ce2 to
8ca6f28
Compare
Collaborator
Pull Request Test Coverage Report for Build 21705299065Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen for both HTTP and HTTPS
This allows us to fully rely on the payjoin-service without a reverse proxy. Without
this change, It's not possible to support TLS bootstrapping and environments, like
Bitcoin Core, which don't have TLS available.
Big GPT-5.2 Codex use here (it wrote every line). manual review of each line. Automated but checked documentation + renames for clarity.
Draft until #1315 is in
Pull Request Checklist
Please confirm the following before requesting review:
AI
in the body of this PR.